BUG: fix alloc tls destruction on gcc#30673
Conversation
|
Thanks for finding the solution. I am wondering if we should add a short comment about it, but not super important. I do wonder if the |
I added a comment with link to the gcc issue. |
|
It looks like the armhf tests are using gcc 13.3, in case it helps. The tests crash on |
|
Hmmm, could it be that we have to explicitly initialize |
|
It failed again with a crash. Not sure how to debug it on such a platform. |
|
I am guessing it might be because |
Ohhh, that would make sense, but in that case we would have to split it up? Debugging it certainly won't be fun :(. |
I've used the tmate action to debug stuff like this on a github runner: https://github.com/mxschmitt/action-tmate Otherwise I think you have an ARM mac, right? You should be able to run Linux in a VM or use orbstack or some other docker environment to run ARM Linux docker containers locally on your Mac to get the armhf container the CI job uses. |
|
It passed with splitting up the cache so it was indeed the size issue. |
|
I'll test it once more in a bit (it worked with the earlier version, so I think it should be OK). This large allocation erroring does make me wonder whether it would be cleaner to allocate this so that thread-local is just the pointer to the cache object?! |
seberg
left a comment
There was a problem hiding this comment.
OK, I can confirm that valgrind is happy with this (and so is GCC 13.3.0).
(If nobody has a thought/opinion if an allocation is better, I'll probably just put it in soon. -- I am happy to follow up myself if we should allocate.)
|
Backport? |
|
No, #30499 wasn't and shouldn't be backported. |
That might be a little slower because statically allocated blocks have better locality than block allocated on heap, given that it is not an issue on major platforms I don't think we should change it. |
|
Thanks for the multiple follow-ups on this one @kumaraditya303. Surprisingly weird/tricky/subtle! |
This reverts commit fba740c.
This reverts commit fba740c.
Addresses the issue discussed at #30499 (comment)