BUG: Ensure summed weights returned by np.average always are correct class #30522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
commented
Dec 26, 2025
| ra, rw = np.average(a, weights=w, returned=True) | ||
| assert_equal(type(ra), subclass) | ||
| assert_equal(type(rw), subclass) | ||
| # Even if it needs to be broadcast. |
Contributor
Author
There was a problem hiding this comment.
This test fails without the subok=True argument.
charris
approved these changes
Dec 26, 2025
Member
|
Thanks Marten. |
Contributor
Author
|
That's quick! Thanks, Chuck. |
charris
added a commit
that referenced
this pull request
Dec 26, 2025
BUG: Ensure summed weights returned by np.average always are correct class (#30522)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at astropy, it was noticed that if one passes in a
Quantityweight tonp.average, and asks for the summed weight to be returned, then the unit can be lost if the shapes of the weights and input array do not match (see astropy/astropy#19054). This is because of a missingsubok=Truein a final broadcast -- which this PR fixes (how I wish I had insisted more that that would be default forsubokwhen it was introduced...).