BUG: fix double evaluation in PyArrayScalar_RETURN_BOOL_FROM_LONG#30418
Conversation
ngoldbaum
left a comment
There was a problem hiding this comment.
A couple minor comments. The C change looks correct to me.
| writer.start() | ||
| reader.start() | ||
| writer.join() | ||
| reader.join() |
There was a problem hiding this comment.
I'd probably write this using ProcessPoolExecutor to avoid this boilerplate and join the processes by construction with a with statement.
There was a problem hiding this comment.
Got it — I’ll switch to ProcessPoolExecutor so the process setup and joining are handled automatically.
37d214d to
1c9a6e5
Compare
|
rebased the commit history to keep only one commit 🚀 |
|
LGTM! @seberg would you mind looking at this one and merging if you agree. |
|
I am happy if you like the test and I guess you do. I was hoping to use advanced indexing and get away with just threading but I am not exactly sure how to design them best to make sure they actually result in a crash :). So thanks @y7070, seems fine to just put it in as is. |
…mpy#30418) * BUG: fix double evaluation in PyArrayScalar_RETURN_BOOL_FROM_LONG Closes numpy#30389 * fix: lint errors and wasm import problems
BUG: fix double evaluation in PyArrayScalar_RETURN_BOOL_FROM_LONG (#30418)
Closes #30389