BUG: numpy.random.* class runtime signatures
#30164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Nov 6, 2025
| cdef get_assembled_entropy(self) | ||
|
|
||
| cdef class SeedlessSequence(): | ||
| cdef class SeedlessSeedSequence: |
Member
There was a problem hiding this comment.
Hmm, probably correct as SeedlessSequence doesn't appear anywhere else. Let's ping @rkern just to be sure.
Member
There was a problem hiding this comment.
I suspect we can remove this alltogether, or maybe fix up some files that import bit_generator.pxd
Member
There was a problem hiding this comment.
This change is correct. SeedlessSeedSequence is the correct spelling. SeedlessSequence never existed, but SeedlessSeedSequence certainly does.
charris
approved these changes
Nov 6, 2025
Member
|
Thanks Joren. |
This was referenced Nov 11, 2025
cakedev0
pushed a commit
to cakedev0/numpy
that referenced
this pull request
Dec 5, 2025
This fixes `inspect.signature` for - `np.random.BitGenerator` - `np.random.Generator` - `np.random.MT19937` - `np.random.PCG64` - `np.random.PCG64DXSM` - `np.random.Philox` - `np.random.RandomState` - `np.random.SFC64` - `np.random.SeedSequence` - `np.random.bit_generator.SeedlessSeedSequence` This also fixes a typo in `bit_generator.pxd` that accidentally defined an empty unused class `np.random.bit_generator.SeedlessSequence`. Related to numpy#30104, numpy#30114, numpy#30121, numpy#30124, numpy#30126, numpy#30137, numpy#30138, numpy#30140, numpy#30143, numpy#30146, numpy#30147, and numpy#30155
IndifferentArea
pushed a commit
to IndifferentArea/numpy
that referenced
this pull request
Dec 7, 2025
This fixes `inspect.signature` for - `np.random.BitGenerator` - `np.random.Generator` - `np.random.MT19937` - `np.random.PCG64` - `np.random.PCG64DXSM` - `np.random.Philox` - `np.random.RandomState` - `np.random.SFC64` - `np.random.SeedSequence` - `np.random.bit_generator.SeedlessSeedSequence` This also fixes a typo in `bit_generator.pxd` that accidentally defined an empty unused class `np.random.bit_generator.SeedlessSequence`. Related to numpy#30104, numpy#30114, numpy#30121, numpy#30124, numpy#30126, numpy#30137, numpy#30138, numpy#30140, numpy#30143, numpy#30146, numpy#30147, and numpy#30155
jorenham
added a commit
to jorenham/numpy
that referenced
this pull request
Dec 22, 2025
seberg
pushed a commit
that referenced
this pull request
Dec 22, 2025
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
inspect.signaturefornp.random.BitGeneratornp.random.Generatornp.random.MT19937np.random.PCG64np.random.PCG64DXSMnp.random.Philoxnp.random.RandomStatenp.random.SFC64np.random.SeedSequencenp.random.bit_generator.SeedlessSeedSequenceThis also fixes a typo in
bit_generator.pxdthat accidentally defined an empty unused classnp.random.bit_generator.SeedlessSequence.Related to #30104, #30114, #30121, #30124, #30126, #30137, #30138, #30140, #30143, #30146, #30147, and #30155