Merged
Conversation
The size argument to random.choice should work like it does for all other functions in random as well.
Random choice used np.unique to find new indices when replace was False and p given. This is wrong since unique will sort the indices. This solves the bug, but likely not ideal.
Thanks to @alan-isaac for pointing out the 0-d vs. scalar issue.
Contributor
Author
|
Hm, Travis didn't run tests.... I pushed in a "Travis ping" commit. Here we go. |
Contributor
Author
|
Ok, all tests passed, so I am removing the "ping" commit and merging. |
Member
|
@certik it was intentional to push this to master and not 1.7.? I just wanted to double check that the results look reasonable and wondered about them being nonsense before realizing that this went into master. |
Contributor
Author
|
All bug fixes go into master first. I just rebased your original PR, which was also against master. Should this be backported to 1.7 as well? |
Member
|
Ah, thanks... I would think it should be in 1.7., because it changes |
Merged
Contributor
Author
|
Ok. Backported in #2820. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also I regenerated the cython file, just in case. We need to run tests on this one to make sure that all passes.