Closed
Conversation
Member
Author
|
Hmm. Maybe we should be using a conditional |
Member
|
A macro seems maybe slightly more convenient, also easier in the sense that we just can skip the Asking users to do the I am a bit tempted to just put this in as docs for now. |
seberg
added a commit
to seberg/numpy
that referenced
this pull request
Aug 11, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it to the migration guide. Closes numpygh-27083
seberg
added a commit
to seberg/numpy
that referenced
this pull request
Aug 11, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it to the migration guide. Closes numpygh-27083 Co-authored-by: Matti Picus <matti.picus@gmail.com>
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Aug 12, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it to the migration guide. Closes numpygh-27083 Co-authored-by: Matti Picus <matti.picus@gmail.com>
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Aug 12, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it to the migration guide. Closes numpygh-27083 Co-authored-by: Matti Picus <matti.picus@gmail.com>
Member
Author
|
Replaced by #27193 |
ArvidJB
pushed a commit
to ArvidJB/numpy
that referenced
this pull request
Nov 1, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it to the migration guide. Closes numpygh-27083 Co-authored-by: Matti Picus <matti.picus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27083
As per the discussion there, add some documentation that hopefully will help users overcome the mess that is
Iincomplex.h.