Skip to content

DOC: add info about complex.h#27105

Closed
mattip wants to merge 1 commit intonumpy:mainfrom
mattip:document-I
Closed

DOC: add info about complex.h#27105
mattip wants to merge 1 commit intonumpy:mainfrom
mattip:document-I

Conversation

@mattip
Copy link
Member

@mattip mattip commented Aug 4, 2024

Closes #27083

As per the discussion there, add some documentation that hopefully will help users overcome the mess that is I in complex.h.

@mattip
Copy link
Member Author

mattip commented Aug 4, 2024

Hmm. Maybe we should be using a conditional #ifdef NPY_USE_COMPLEX to enable/disable the override?

@seberg
Copy link
Member

seberg commented Aug 5, 2024

A macro seems maybe slightly more convenient, also easier in the sense that we just can skip the undef, I guess. Not sure about the name NPY_USE_COMPLEX sounds a bit like we might avoid pulling in complex.h completely without it (which I don't think we would?).

Asking users to do the #undef I would be the better thing, but if it adds odd errors with boost, also not really better :(.

I am a bit tempted to just put this in as docs for now.

seberg added a commit to seberg/numpy that referenced this pull request Aug 11, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it
to the migration guide.

Closes numpygh-27083
seberg added a commit to seberg/numpy that referenced this pull request Aug 11, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it
to the migration guide.

Closes numpygh-27083

Co-authored-by: Matti Picus <matti.picus@gmail.com>
charris pushed a commit to charris/numpy that referenced this pull request Aug 12, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it
to the migration guide.

Closes numpygh-27083

Co-authored-by: Matti Picus <matti.picus@gmail.com>
charris pushed a commit to charris/numpy that referenced this pull request Aug 12, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it
to the migration guide.

Closes numpygh-27083

Co-authored-by: Matti Picus <matti.picus@gmail.com>
@mattip
Copy link
Member Author

mattip commented Aug 12, 2024

Replaced by #27193

@mattip mattip closed this Aug 12, 2024
ArvidJB pushed a commit to ArvidJB/numpy that referenced this pull request Nov 1, 2024
This is based on what Matti wrote in numpygh-27105 but also adding it
to the migration guide.

Closes numpygh-27083

Co-authored-by: Matti Picus <matti.picus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Compiling C extension against numpy 2.0.1 fails with error: 'I' undeclared

2 participants