Skip to content

BUG: Bump Highway to latest master#27070

Merged
charris merged 2 commits into
numpy:mainfrom
Mousius:highway-bump
Jul 29, 2024
Merged

BUG: Bump Highway to latest master#27070
charris merged 2 commits into
numpy:mainfrom
Mousius:highway-bump

Conversation

@Mousius

@Mousius Mousius commented Jul 29, 2024

Copy link
Copy Markdown
Member

Fixes #27037

@r-devulap r-devulap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neutrinoceros verified that this patch fixes the bug. #27037 (comment)

@r-devulap

Copy link
Copy Markdown
Member

I checked why our tests did not find this, and it's because they generate random 32-bit values which are very unlikely to have many duplicates. We can also run them with 8-bit values.

@Mousius could you add a test in NumPy to add coverage for such sorting array with duplicate values?
Ref #27037 (comment)

@Mousius

Mousius commented Jul 29, 2024

Copy link
Copy Markdown
Member Author

@r-devulap lets not talk about how the test was the first thing I wrote and still forgot to include it in the PR 🙀

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Jul 29, 2024
@charris charris merged commit 50bd355 into numpy:main Jul 29, 2024
@charris

charris commented Jul 29, 2024

Copy link
Copy Markdown
Member

Thanks @Mousius .

charris pushed a commit to charris/numpy that referenced this pull request Jul 29, 2024
* Bump Highway to latest master

Fixes numpy#27037

* Add reproducer
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jul 29, 2024
charris pushed a commit to charris/numpy that referenced this pull request Jul 29, 2024
* Bump Highway to latest master

Fixes numpy#27037

* Add reproducer
ArvidJB pushed a commit to ArvidJB/numpy that referenced this pull request Nov 1, 2024
* Bump Highway to latest master

Fixes numpy#27037

* Add reproducer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: random segmentation fault in np.unique on MacOS (arm64) + numpy 2.0.1

3 participants