DOC: Fix migration note for alltrue and sometrue#27015
Merged
rgommers merged 1 commit intonumpy:mainfrom Jul 23, 2024
Merged
Conversation
Member
Author
|
@rgommers I see that I took it from the deprecation message added here: 9990f98 I think in: and you meant |
rgommers
approved these changes
Jul 23, 2024
Member
rgommers
left a comment
There was a problem hiding this comment.
LGTM, thanks @mtsokol.
you meant
np.allandnp.any, not the Python builtins, right? As the release note states.
Yes indeed. That seemed clear to me even without the np. - I think all the surrounding notes with the np. included were written later. Nevertheless, this PR makes it more clear, so in it goes.
alltrue and sometruealltrue and sometrue
Member
|
Certainly not a bug I'd say - changed to |
Member
|
Backporting sounds fine to me, in case we do a 2.0.2 release - label added. |
alltrue and sometruealltrue and sometrue
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jul 24, 2024
ArvidJB
pushed a commit
to ArvidJB/numpy
that referenced
this pull request
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ngoldbaum,
I think I made a mistake in #26517 as pointed out it in astral-sh/ruff#12416.
np.sometrueandnp.alltrueshould be mapped tonp.anyandnp.allinstead of Python builtinsany/all. (It could be also backported).