DOC: Extend release notes for #26611#26737
Conversation
There was a problem hiding this comment.
Thanks the change looks good and thanks a lot of the quick follow-up. Sorry for not commenting earlier there.
I'll leave it open in case others want to dicuss (@mhvk might have a thought on printing).
I like the thought of adding a new mechanism for overriding that is part of printoptions, it just seems to make sense to me, although I don't know if anyone uses it :).
Thinking a bit about it now: I wonder if the old version of stringfunc(array, repr=False/True) wasn't better, though? Passing repr avoids the possible wish to add another option for str later at very little cost.
(At which point the name might be a question "override" is not a bad term, maybe even override_func, although also fine to to go with str or repr and just have the kwarg anyway.)
|
Thanks for the ping, I had indeed missed that the previous PR did not only remove |
|
Yeah, that was a thought, just to add fewer arguments. But I don't mind the approach of having two kwargs, either (in which case, there is also no rush). |
|
Ping @jni @GenevieveBuckley, I noticed the trouble you had in napari/napari#6776, this should help you get back the shorter repr you had before. |
|
Thanks Mateusz. I went ahead and merged this because the implementation is already in and the discussion seems to be mostly about alternatives. |
Hi @seberg,
Addresses #26611 (comment).