TST: account for immortal objects in test_iter_refcount#26207
Merged
ngoldbaum merged 1 commit intonumpy:mainfrom Apr 8, 2024
Merged
TST: account for immortal objects in test_iter_refcount#26207ngoldbaum merged 1 commit intonumpy:mainfrom
ngoldbaum merged 1 commit intonumpy:mainfrom
Conversation
16 tasks
seberg
approved these changes
Apr 3, 2024
Member
seberg
left a comment
There was a problem hiding this comment.
Hummm, interesting that it manages that for statically allocated instances, but I guess the PyObject_HEAD code does so. We could also use sys.getrefcount(dt) > rc2_dt or immortal(dt)?
But unless that seems like a good idea to you immediately, this looks fine to me.
Member
Author
|
Thanks! I think the comment is sufficient to explain what's going on for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per PEP 703, objects that are automatically immortal in the nogil build include:
That means
np.dtype('f4')is immortal, because all the legacy descriptors are declared statically:numpy/numpy/_core/src/multiarray/arraytypes.c.src
Lines 4042 to 4053 in ffb23cd
As far as I can tell, this is the only test in the test suite that depends on INCREF or DECREF for a built-in dtype not being a no-op.
The spelling I've used to detect the nogil build is also what CPython uses internally: https://github.com/python/cpython/blob/7ecd55d604a8fa287c1d131cac14d10260be826b/Lib/test/support/__init__.py#L839