BUG: fix refcounting for dtypemeta aliases#25329
Merged
ngoldbaum merged 1 commit intonumpy:mainfrom Dec 6, 2023
Merged
Conversation
Member
|
NewRef is nice, maybe we should just put it into the |
seberg
approved these changes
Dec 6, 2023
Member
seberg
left a comment
There was a problem hiding this comment.
LGTM, thanks, please feel free to merge. I guess this version can be a static inline functions (want to avoid the need for casting here for sure).
Contributor
|
Thanks for the quick fix! When should I expect a new nightly wheel with this patch? |
Member
Author
|
When this actions run finishes. |
Contributor
|
Looks like the build failed for |
Member
Author
|
It looks like that's due to #25149, i'll open another issue about it. |
hawkinsp
added a commit
to hawkinsp/numpy
that referenced
this pull request
Sep 30, 2024
We didn't take a reference to this type, so we shouldn't be freeing one. This appears to have been missed by PR numpy#25329.
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Sep 30, 2024
We didn't take a reference to this type, so we shouldn't be freeing one. This appears to have been missed by PR numpy#25329.
ArvidJB
pushed a commit
to ArvidJB/numpy
that referenced
this pull request
Nov 1, 2024
We didn't take a reference to this type, so we shouldn't be freeing one. This appears to have been missed by PR numpy#25329.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25327.
I introduced
NPY_DT_NewRef, which is basically the same asPy_NewRef. If we aren't supporting Python 3.9 I could just usePy_NewRefinstead.