DOC: f2py CLI documentation enhancements#25124
Conversation
Not handled outside distutils anyway
f2py CLI documentation enhancements
numpy/f2py/auxfuncs.py
Outdated
| Copyright 1999,2000 Pearu Peterson all rights reserved, | ||
| Pearu Peterson <pearu@ioc.ee> | ||
| Copyright 1999 - 2011 Pearu Peterson all rights reserved. | ||
| Copyright 2011 - 2023 NumPy Developers. |
There was a problem hiding this comment.
Do we have precedent for adding another copyright line to modified files? I think this is covered by the overall project license, but if you feel strongly then perhaps we should simply remove the dates altogether, as suggested here to prevent additional yearly maintenance burden.
There was a problem hiding this comment.
I don't think we can / should remove Pearu's original copyright line, but at the same time I wanted to emphasize the current state of maintenance. Does 2012--present sound alright?
Edit: Note that the License.txt has both beginning (2005) and end (2023) dates.
numpy/f2py/auxfuncs.py
Outdated
| Copyright 1999 - 2011 Pearu Peterson all rights reserved. | ||
| Copyright 2011 - 2023 NumPy Developers. |
There was a problem hiding this comment.
Maybe remove the years, they only add maintenance burden without really affecting the legal status of the statement (see the link above). So something like this, or even without the NumPy developers line (which is covered by the regular license).
| Copyright 1999 - 2011 Pearu Peterson all rights reserved. | |
| Copyright 2011 - 2023 NumPy Developers. | |
| Copyright Pearu Peterson all rights reserved. | |
| Copyright NumPy Developers. |
There was a problem hiding this comment.
I understand the argument in the link, but here it would be nonsensical to have both all rights reserved under one name and also have the other. The years are important in the sense that it shows a transition in the copyright holders. So I would probably prefer 1999-2011 for Pearu and 2012 onwards or 2012--present for NumPy
There was a problem hiding this comment.
IANAL. I think the whole change is not needed, but am open to accepting other views.
There was a problem hiding this comment.
Fair enough, it was a single commit I'm happy to revert, the rest of this really needs to be in ASAP, lots of confusion regarding the meson backend and f2py.
There was a problem hiding this comment.
Reverted for now, though I think its worth a discussion, opened #25137 for later.
34d99b8 to
14ca2cb
Compare
14ca2cb to
d36e8a7
Compare
|
Seems reasonable from what I can see. I am troubled by the lack of test coverage. Did you try this out both on distutils-based pre-3.12 and on meson? |
Yup, I tested (and passed CI with The documented changes here are already in the code (in an ideal world they should have been part of the 1.26 release where the |
|
Thanks @HaoZeke |
f2py CLI documentation enhancementsf2py CLI documentation enhancements
f2pyCLI documentation enhancements:f2pynow mentions [NO_MESON] optionsabsoftflag from the help text