TST: Initialize f2py2e tests of the F2PY CLI by HaoZeke · Pull Request #20668 · numpy/numpy

HaoZeke · 2021-12-26T20:26:13Z

Essentially this branch: HaoZeke/f2py_skel#15

Increases F2PY coverage by around 15 percent. For the CLI itself it covers the major features (around 70 percent), with the exception of mostly numpy.distutils stuff.

More importantly, sets the groundwork for #20056, in that passing the same testsuite should indicate feature parity.

Does not depend on the refactors.

Changes:

Tests for most of the current CLI

HaoZeke · 2021-12-26T20:27:29Z

I tested all the pytest capture mechanisms and nothing other than --capture=tee-sys would do for capturing the stderr stream f2py writes to.

Setting up special handling for f2py tests in runpython.py seemed clunky so adding to the global set seemed like the best move. Does not change any existing tests (other than to make the f2py ones a bit more verbose).

charris · 2021-12-28T01:35:10Z

numpy/f2py/tests/src/cli/hi77.f

@@ -0,0 +1,3 @@
+      SUBROUTINE HI


These could probably use a renaming to hello_world77.f or some such.

Should the other be renamed similarly? We currently have hi77.f and hiworld.f90. It'd be good to have a template name format and redo all of them at once, all the test sources are oddly named.

all the test sources are oddly named.

Having consistent names would be nice. It isn't a priority, but feel free to do it. It is currently hard to figure out what all the tests do. What ideas do you have for a "template name format"?

I think using the test name or after the refactor the submodule name so:

cli_hello_world.f77

cli_hello_world.f90

frontend_no_space (instead of gh15035.f)

Essentially from what we have, even submodule_test_name is an upgrade.
Perhaps in a different PR though?

I agree, avoiding names like hi and blah seems like a good idea in general. Not a blocker though.

charris · 2021-12-28T01:37:07Z

for capturing the stderr stream

Will those errors eventually be Python exceptions?

charris · 2021-12-28T01:38:51Z

Still some errors.

HaoZeke · 2021-12-30T16:40:52Z

for capturing the stderr stream

Will those errors eventually be Python exceptions?

I don't think so. These are basically written to sys.stderr and sys.stdout during the wrapper generation, not during the execution of the module itself so I don't think it makes sense to have these be Python exceptions (in that we aren't really planning to handle them or anything).

However I have considered reworking the F2PY logging system with logging, which would clean all of this up a lot.

EDIT: Somehow one of the sys.stderr write-outs wasn't working (buffering issues?), but having fixed that (in a rather ham handed way, with print("blah", file=sys.stderr) this PR no longer adds to the numpy pytest.ini file.

HaoZeke · 2021-12-30T17:48:30Z

I'm not sure I know what's wrong with the Windows tests, some (32-bit) seem to be related to not finding gfortran-5 and the others seem to have to do with different outputs which break the assertions (which definitely shouldn't happen).... Perhaps someone with more experience of the numpy Azure pipelines could shed some light on this?

melissawm · 2022-02-22T21:51:38Z

I'm not sure I know what's wrong with the Windows tests, some (32-bit) seem to be related to not finding gfortran-5 and the others seem to have to do with different outputs which break the assertions (which definitely shouldn't happen).... Perhaps someone with more experience of the numpy Azure pipelines could shed some light on this?

Not sure about the 32-bit tests but running on windows confirms the problem with the slashes in the assert for outputs.

From HaoZeke/f2py_skel#15

melissawm · 2022-04-01T13:05:22Z

This is looking good now, so let's try it - thanks @HaoZeke !

Increases F2PY coverage by around 15 percent. For the CLI itself it covers the major features (around 70 percent), with the exception of mostly numpy.distutils stuff. More importantly, sets the groundwork for numpy#20056, in that passing the same testsuite should indicate feature parity.

HaoZeke added 05 - Testing component: numpy.f2py labels Dec 26, 2021

HaoZeke requested a review from melissawm December 26, 2021 20:26

HaoZeke force-pushed the f2py2eTests branch 5 times, most recently from bc5cb05 to 6fa453d Compare December 27, 2021 15:24

charris reviewed Dec 28, 2021

View reviewed changes

HaoZeke force-pushed the f2py2eTests branch from 6fa453d to 1dfee74 Compare December 30, 2021 16:30

HaoZeke mentioned this pull request Mar 12, 2022

ENH: F2PY build output determinism #21187

Merged

3 tasks

HaoZeke added 3 commits March 21, 2022 01:54

TST: Capture all stdout/stderr streams

32caf50

TST: Initialize f2py2e cli tests

99a56a9

From HaoZeke/f2py_skel#15

TST: Pass on Windows

6556d84

HaoZeke force-pushed the f2py2eTests branch from 1dfee74 to 6556d84 Compare March 21, 2022 02:26

TST: Xfail a few f2py2e tests

f9ee452

melissawm merged commit 729ad4f into numpy:main Apr 1, 2022

HaoZeke mentioned this pull request Nov 13, 2023

DOC: f2py CLI documentation enhancements #25124

Merged

HaoZeke deleted the f2py2eTests branch November 13, 2023 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TST: Initialize f2py2e tests of the F2PY CLI#20668

TST: Initialize f2py2e tests of the F2PY CLI#20668
melissawm merged 4 commits intonumpy:mainfrom
HaoZeke:f2py2eTests

HaoZeke commented Dec 26, 2021

Uh oh!

HaoZeke commented Dec 26, 2021 •

edited

Loading

Uh oh!

charris Dec 28, 2021

Uh oh!

HaoZeke Dec 30, 2021

Uh oh!

charris Dec 30, 2021

Uh oh!

HaoZeke Dec 30, 2021 •

edited

Loading

Uh oh!

melissawm Jan 13, 2022

Uh oh!

charris commented Dec 28, 2021

Uh oh!

charris commented Dec 28, 2021

Uh oh!

HaoZeke commented Dec 30, 2021 •

edited

Loading

Uh oh!

HaoZeke commented Dec 30, 2021

Uh oh!

melissawm commented Feb 22, 2022

Uh oh!

melissawm commented Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

HaoZeke commented Dec 26, 2021

Uh oh!

HaoZeke commented Dec 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

charris Dec 28, 2021

Choose a reason for hiding this comment

Uh oh!

HaoZeke Dec 30, 2021

Choose a reason for hiding this comment

Uh oh!

charris Dec 30, 2021

Choose a reason for hiding this comment

Uh oh!

HaoZeke Dec 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melissawm Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

charris commented Dec 28, 2021

Uh oh!

charris commented Dec 28, 2021

Uh oh!

HaoZeke commented Dec 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HaoZeke commented Dec 30, 2021

Uh oh!

melissawm commented Feb 22, 2022

Uh oh!

melissawm commented Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HaoZeke commented Dec 26, 2021 •

edited

Loading

HaoZeke Dec 30, 2021 •

edited

Loading

HaoZeke commented Dec 30, 2021 •

edited

Loading