MAINT: Bump actions/setup-node from 3.6.0 to 3.7.0#24124
Merged
Conversation
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.6.0 to 3.7.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@64ed1c7...e33196f) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
seberg
added a commit
that referenced
this pull request
Jan 20, 2024
…r`` (#25409) This reorganize how array-wrap is called. It might very mildly change the semantics for reductions I think (and for negative priorities). Overall, it now passes a new return_scalar=False/True when calling __array_wrap__ and deprecates any array-wrap which does not accept arr, context, return_scalar. I have not integrated it yet, but half the reason for the reorganization is to integrate it/reuse it in the array_coverter helper PR (gh-24214), which stumbled over trying to make the scalar handling sane. Forcing downstream to add return_scalar=False to the signature is a bit annoying, but e.g. our memory maps currently try to guess at it, which seems bad. I am hoping, this can be part to making the scalar vs. array return more sane. But, maybe mainly, I hope it consolidates things (together with gh-24124 mainly, as if ufuncs were the only complex place we used this, it wouldn't matter much). --- * API: Reorganize `__array_wrap__` and add `return_scalar=False` This also deprecates any `__array_wrap__` which does not accept `context` and `return_scalar`. * BUG: Fix niche bug in rounding. * MAINT: Adjust __array_wrap__ in code and tests (also deprecation test) * MAINT: Use/move the simplest C-wrapping also * DOC: Update doc and add release note * STY: Make linter happy in old tests * MAINT: Silence GCC warning (value cannot really be used uninitialized) * MAINT: Small style fixes * BUG: Fix reference leak in ufunc array-wrapping This probably doesn't fix the 32bit issue unfortunately, only the windows ones... * BUG: Fix leak for result arrays in all ufunc calls * Ensure we try passing context and address related smaller review comments * Ensure we don't try `context=None` and expand code comment * Rely on return_scalar always being right (and style nit) * Remove outdated comments as per review * Let's just undo force-wrap for now for reductions (its a change...) * ENH: Chain the original error when the deprecationwarning is raised Doing this due to gh-25635 since it is super confusing with the bad retrying... * BUG,MAINT: Address Martens review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/setup-node from 3.6.0 to 3.7.0.
Release notes
Sourced from actions/setup-node's releases.
Commits
e33196fDo not ivalidate the cache entirely on lock file change (#744)c6722d3update doc for frozen lock file (#789)8170e22Detect cached folders from multiple directories (#735)698d505Fix description about ensuring workflow access to private package (#704)869f4ddMerge pull request #758 from akv-platform/remove-implicit-dependencies10efafcUpdate canary version in tests to an existing one7d16907Add missing dependencyd0d39bdMove eslint-plugin-node to dev dependencies15a2477Install eslint-plugin-node7598dbcUpdate configuration filesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)