DEP: Expire set_numeric_ops and the corresponding C functions deprecation#23998
Merged
seberg merged 2 commits intonumpy:mainfrom Jun 20, 2023
Merged
DEP: Expire set_numeric_ops and the corresponding C functions deprecation#23998seberg merged 2 commits intonumpy:mainfrom
set_numeric_ops and the corresponding C functions deprecation#23998seberg merged 2 commits intonumpy:mainfrom
Conversation
…cation This simply expires the deprecations because I saw they were one cause of doctest failures in the other PR, but its good anyway.
Unlike the set version, we don't use it internally.
mhvk
reviewed
Jun 19, 2023
Contributor
mhvk
left a comment
There was a problem hiding this comment.
Clean-up is nice! But it looks like one should be able to get rid of number.c and number.h altogether! (moving some code to umathmodule)
mhvk
approved these changes
Jun 20, 2023
Contributor
mhvk
left a comment
There was a problem hiding this comment.
With that conversation resolved, I think this is all good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply expires the deprecations because I saw they were one cause of doctest failures in the other PR, but its good anyway.