API: Change string to bool conversions to be consistent with Python#23898
Merged
charris merged 1 commit intonumpy:mainfrom Jun 9, 2023
Merged
API: Change string to bool conversions to be consistent with Python#23898charris merged 1 commit intonumpy:mainfrom
charris merged 1 commit intonumpy:mainfrom
Conversation
This changes casts from strings to bool to use the length (and not go via integers). Further, `nonzero` behavior was taking into account spaces previously. There is for users to silently always getting `False` now if they used the integer conversion logic (making their code wrong).
Member
|
For what it's worth, this is also how |
Member
Author
|
I will consider this a 👍, I think @stefanv was also in favor? |
mhvk
reviewed
Jun 9, 2023
Contributor
mhvk
left a comment
There was a problem hiding this comment.
Certainly makes sense to me (and code looks good)
Contributor
|
Yes, I appreciate the consistency with Python. |
Member
|
Thanks Sebastian. |
seberg
added a commit
to seberg/numpy
that referenced
this pull request
Jan 22, 2024
I didn't allow them because casting strings to bools made no sense at all. But that was fixed in numpygh-23898. I am very sure the deprecation is expired and I simply forgot to remove that branch also. Closes numpygh-1912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes casts from strings to bool to use the length (and not go via integers).
Further,
nonzerobehavior was taking into account spaces previously.There is for users to silently always getting
Falsenow if they used the integer conversion logic (making their code wrong).Most parsing functions are not affected by this, but manually parsing can be and so is
np.fromregexunfortunately.Closes gh-9875