Skip to content

DEP: remove deprecated casting in np.clip#23403

Merged
seberg merged 4 commits intonumpy:mainfrom
mattip:clip-cleanup
Mar 16, 2023
Merged

DEP: remove deprecated casting in np.clip#23403
seberg merged 4 commits intonumpy:mainfrom
mattip:clip-cleanup

Conversation

@mattip
Copy link
Copy Markdown
Member

@mattip mattip commented Mar 16, 2023

Remove casting=None from np.clip that was deprecated in NumPy 1.17

Signed-off-by: Matti Picus <matti.picus@gmail.com>
Copy link
Copy Markdown
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had set that to "expired", but then realized we may want to be a bit more precise, could you have a look @mattip?

This is great! Just should tweak that release note, I think.

@mattip mattip requested a review from seberg March 16, 2023 19:29
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
@seberg
Copy link
Copy Markdown
Member

seberg commented Mar 16, 2023

Lets get it in then, thanks.

@seberg seberg merged commit e42c950 into numpy:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants