Ah... looks reasonable :) The other thing that might be worth checking is that it uploads to the staging repo. I think that should be the case for all maintenance branches.

As it stands the code should upload any tag that begins with v, no matter what branch it originally came from.

no matter what branch it originally came from

Uploads from main should go to nightly, from branches to staging. The only tags we currently push to main are of the form "v1.25.0.dev0", and we could safely ignore those. I'm a bit concerned because the manual build of 1.24.x uploaded to nightly.

At the moment all manual builds are classified as IS_SCHEDULED_DISPATCH,

Do you want tags from main to go to nightly, and tags from maintenance branches to go to staging?

That would be good. Or you can just ignore tags on main.

Ok, now tags beginning with v and are on a maintenance branch get uploaded to staging (IS_PUSH=true). cron/manual builds will still get uploaded to nightly (IS_SCHEDULE_DISPATCH=true).

Thanks Andrew.

@andyfaff This didn't fix the problem, there was still no upload with the v1.24.0 tag push.