MAINT: remove macOS specific long double handling in numpyconfig.h#22614
Merged
mattip merged 1 commit intonumpy:mainfrom Nov 17, 2022
Merged
MAINT: remove macOS specific long double handling in numpyconfig.h#22614mattip merged 1 commit intonumpy:mainfrom
mattip merged 1 commit intonumpy:mainfrom
Conversation
This was put in place for universal builds (the old kind, PPC/Intel), and then extended for arm64 support. It was only needed when building for two architectures in a single build. We no longer support i386/PPC/universal, and for producing universal2 wheels for those users that want that, the way to do it is to take a x86-64 wheel and an arm64 wheel and fuse those with the `delocate-fuse` utility from `delocate`. Hence this code is no longer needed.
Member
|
Seems reasonable. Thanks @rgommers |
Member
Author
I'll also note that if there's a diehard PowerPC user out there still, this PR should not actually break anything. |
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Dec 15, 2022
…macOS Reverts numpygh-22614, and adds more detail about why that code is needed and when it can be removed. Closes numpygh-22796 [skip cirrus] [skip circle]
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Dec 15, 2022
…macOS Reverts numpygh-22614, and adds more detail about why that code is needed and when it can be removed. Closes numpygh-22796 [skip cirrus] [skip circle]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was put in place for universal builds (the old kind, PPC/Intel), and then extended for arm64 support. It was only needed when building for two architectures in a single build.
We no longer support i386/PPC/universal, and for producing universal2 wheels for those users that want that, the way to do it is to take a x86-64 wheel and an arm64 wheel and fuse those with the
delocate-fuseutility fromdelocate.Hence this code is no longer needed.