ENH: avoid looping when dimensions[0] == 0 or array.size == 0#21499
Merged
mattip merged 1 commit intonumpy:mainfrom May 12, 2022
Merged
ENH: avoid looping when dimensions[0] == 0 or array.size == 0#21499mattip merged 1 commit intonumpy:mainfrom
mattip merged 1 commit intonumpy:mainfrom
Conversation
Member
|
Ack, just also spend way too much time trying to frickle that "first visit" loop nicer. Plus, I couldn't find any other dubious paths in the ufunc machinery right now. Thanks! Please go ahead and just self-merge once things pass. A bit tricky to make sure we never call the inner-loop with an empty count, but overall there seems no real point in not checking early on. |
Member
|
The test failure should be fixed by gh-21500, it has nothing to do with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #21477
There is no need to enter a ufunc loop if the array is empty. These were detected by using the assert in the PR together with
CFLAGS="-O0 -g3 -UNDEBUG"