TST: Fix uninitialized value in masked ndenumerate test#21500
Merged
seberg merged 1 commit intonumpy:mainfrom May 12, 2022
Merged
TST: Fix uninitialized value in masked ndenumerate test#21500seberg merged 1 commit intonumpy:mainfrom
seberg merged 1 commit intonumpy:mainfrom
Conversation
The test used unintialized values, if NaN happened to be there the test would fail (and generally, uninitialized values being used in tests is bad, since it shows up in valgrind).
Member
|
Thanks, nice catch. |
mattip
approved these changes
May 12, 2022
Member
|
Hmm, I wonder if a similar thing might be happening with the occasional matmul test failures we see. |
Member
Author
|
Maybe, but it would have to be a lot more subtle than this. If we clearly forget to initialize memory, we would have noticed it long ago when checking with valgrind (unless it is uninitialized memory on the stack!). Another way to get to unitialized memory/randomness might be due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test used unintialized values, if NaN happened to be there
the test would fail (and generally, uninitialized values being used
in tests is bad, since it shows up in valgrind).