Skip to content

MAINT: Fix failing simd and cygwin tests.#21347

Merged
charris merged 1 commit intonumpy:mainfrom
charris:fix-failing-tests
Apr 16, 2022
Merged

MAINT: Fix failing simd and cygwin tests.#21347
charris merged 1 commit intonumpy:mainfrom
charris:fix-failing-tests

Conversation

@charris
Copy link
Copy Markdown
Member

@charris charris commented Apr 15, 2022

The breakage was likely due to a git version update. May need a backport.

@charris
Copy link
Copy Markdown
Member Author

charris commented Apr 15, 2022

Not yet sure about the cygwin test, this is a work in progress until verfied.

@charris charris force-pushed the fix-failing-tests branch from 76e56aa to b4f16db Compare April 15, 2022 20:51
@charris
Copy link
Copy Markdown
Member Author

charris commented Apr 15, 2022

The cygwin test is fixed. Not sure what is going on with the SIMD test, it started failing 3 days ago and it looks like a missing v1.23.0.dev0 tag, but the tag is there in the checkout, so something else has changed. Docker perhaps?

EDIT1: Maybe git?
EDIT2: The latest git was released 2022-04-13. The cygwin problem may also have been due to git.

I suspect a git version update was responsible.
@charris charris force-pushed the fix-failing-tests branch from f47540e to fb5f1a7 Compare April 16, 2022 06:27
@charris charris added 09 - Backport-Candidate PRs tagged should be backported and removed 25 - WIP labels Apr 16, 2022
@charris charris added this to the 1.22.4 release milestone Apr 16, 2022
@charris charris merged commit 7b92cee into numpy:main Apr 16, 2022
@charris charris deleted the fix-failing-tests branch April 16, 2022 14:29
@charris charris added component: CI and removed 09 - Backport-Candidate PRs tagged should be backported labels Apr 16, 2022
@charris charris removed this from the 1.22.4 release milestone Apr 16, 2022
DWesl added a commit to DWesl/scipy that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant