ENH: add hook and test for PyInstaller.#20745
Merged
charris merged 1 commit intonumpy:mainfrom Jan 24, 2022
bwoodsend:pyinstaller-hook
Merged
ENH: add hook and test for PyInstaller.#20745charris merged 1 commit intonumpy:mainfrom bwoodsend:pyinstaller-hook
charris merged 1 commit intonumpy:mainfrom
bwoodsend:pyinstaller-hook
Conversation
rgommers
reviewed
Jan 7, 2022
Member
rgommers
left a comment
There was a problem hiding this comment.
This looks really good, thanks @bwoodsend!
Contributor
Author
|
The two travis failures will disappear when PyInstaller next releases (which was supposed to be this morning) shipping pre-compiled wheels for those architectures. Something unpleasant appears to have knocked out installing cygwin. Hopefully egor-tensin/setup-cygwin will mop it up quickly. What's wrong with Windows 32bit on Azure is a mystery to me. |
Contributor
Author
|
PyInstaller's |
Adding this special hook file tells PyInstaller what files a self contained NumPy application needs to run. A test is included to verify that the hook still finds all necessary files. Closes #17184.
Contributor
Author
|
That's this rebased so as to include #20831. |
Member
|
Thanks @bwoodsend . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this special hook file tells PyInstaller what files a self contained NumPy application needs to run. A test is encluded to verify that the hook still finds all necessary files.
Closes #17184.