Skip to content

BUG: Avoid importing numpy.distutils on import numpy.testing#20831

Merged
rgommers merged 1 commit intonumpy:mainfrom
bwoodsend:numpy-testing-depends-on-distutils
Jan 20, 2022
Merged

BUG: Avoid importing numpy.distutils on import numpy.testing#20831
rgommers merged 1 commit intonumpy:mainfrom
bwoodsend:numpy-testing-depends-on-distutils

Conversation

@bwoodsend
Copy link
Contributor

Move the offending imports into the functions that use them so that numpy.distutils is only loaded if those functions are required. Fixes #20769.

Move the offending imports into the functions that use them so that
numpy.distutils is only loaded if those functions are required.
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Jan 16, 2022
@charris charris added this to the 1.22.2 release milestone Jan 16, 2022
@bwoodsend bwoodsend marked this pull request as ready for review January 16, 2022 17:37
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bwoodsend!

@rgommers rgommers merged commit d3dcb04 into numpy:main Jan 20, 2022
@bwoodsend bwoodsend deleted the numpy-testing-depends-on-distutils branch January 20, 2022 20:07
@InessaPawson
Copy link
Member

Hi-five on merging your first pull request to NumPy, @bwoodsend! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute
Also, consider joining our mailing list. This is a great way to connect with other cool people in our community and be part of important conversations that affect the development of NumPy: https://mail.python.org/mailman/listinfo/numpy-discussion

@charris charris changed the title BUG: Avoid importing numpy.distutils on import numpy.testing (#20769) BUG: Avoid importing numpy.distutils on import numpy.testing Jan 27, 2022
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jan 27, 2022
@charris charris removed this from the 1.22.2 release milestone Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: numpy.testing now depends on numpy.distutils

4 participants