BUG, SIMD: Workaround broadcasting SIMD 64-bit integers on MSVC 32-bit#20219
Merged
charris merged 3 commits intonumpy:mainfrom Oct 28, 2021
Merged
BUG, SIMD: Workaround broadcasting SIMD 64-bit integers on MSVC 32-bit#20219charris merged 3 commits intonumpy:mainfrom
charris merged 3 commits intonumpy:mainfrom
Conversation
53ac11b to
450e745
Compare
Member
|
Let's give this a shot. Thanks Sayed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid using any of intrinsics that related to broadcasting 64-bit integers
with MSVC 32-bit, even if they are apparently work on newer versions.
They had bad impact on the generated instructions, sometimes the
compiler deal with them without the respect of 32-bit mode which
lead to crush due to execute 64-bit instructions and other times
generate bad emulated instructions.
closes #20216