Merged
Conversation
There was a build issue on numpy with M1:
AssertionError: would build wheel with unsupported tag ('cp39', 'cp39', 'macosx_11_0_universal2')
The issue was fixed in the packaging 20.5 and onwards, but that was not
getting picked by setuptools. So explicitly adding this dependency in
the toml file. The change was tested with:
```
python3 -m pip install --force-reinstall .
```
mattip
reviewed
Mar 4, 2021
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Member
|
Did you verify this is correct? We don't build/test for M1 here |
Contributor
Author
Yes, I used |
Contributor
Author
|
Some of the tests are failing with: @mattip How to find out if this is related to this change ? Any help would be appreciated. |
Member
It's a bug in the manylinux2010 image released last Wednesday. Fixed in NumPy by pinning manylinux2010 to the previous version, and now fixed upstream as well. |
Member
|
Thanks @kulinseth |
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Jul 10, 2022
Why we don't need this anymore: - This pin for `packaging` 20.5 was added in numpygh-18538. - `setuptools` then upgraded its vendored `packaging` version to 21.2 in its 59.1.0 release (see https://setuptools.pypa.io/en/latest/history.html?highlight=%22update%20packaging%22#v59-1-0) - And we then upgraded to `setuptools` 59.2.0 in commit 1adb70d We do not depend on `packaging` at all, it was a pin of a transitive build dependency. So let's clean it up. Tested locally as well with `python -m build --wheel` (which uses `pyproject.toml` to build a wheel in an isolated venv), and then checking the wheel tags and ensuring the wheel can be installed with Pip.
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Jul 10, 2022
Why we don't need this anymore: - This pin for `packaging` 20.5 was added in numpygh-18538. - `setuptools` then upgraded its vendored `packaging` version to 21.2 in its 59.1.0 release (see https://setuptools.pypa.io/en/latest/history.html?highlight=%22update%20packaging%22#v59-1-0) - And we then upgraded to `setuptools` 59.2.0 in commit 1adb70d We do not depend on `packaging` at all, it was a pin of a transitive build dependency. So let's clean it up. Tested locally as well with `python -m build --wheel` (which uses `pyproject.toml` to build a wheel in an isolated venv), and then checking the wheel tags and ensuring the wheel can be installed with Pip. [ci skip]
rgommers
added a commit
to rgommers/numpy
that referenced
this pull request
Jul 10, 2022
Why we don't need this anymore: - This pin for `packaging` 20.5 was added in numpygh-18538. - `setuptools` then upgraded its vendored `packaging` version to 21.2 in its 59.1.0 release (see https://setuptools.pypa.io/en/latest/history.html#v59-1-0) - And we then upgraded to `setuptools` 59.2.0 in commit 1adb70d We do not depend on `packaging` at all, it was a pin of a transitive build dependency. So let's clean it up. Tested locally as well with `python -m build --wheel` (which uses `pyproject.toml` to build a wheel in an isolated venv), and then checking the wheel tags and ensuring the wheel can be installed with Pip. [ci skip]
NamamiShanker
pushed a commit
to NamamiShanker/numpy
that referenced
this pull request
Jul 13, 2022
Why we don't need this anymore: - This pin for `packaging` 20.5 was added in numpygh-18538. - `setuptools` then upgraded its vendored `packaging` version to 21.2 in its 59.1.0 release (see https://setuptools.pypa.io/en/latest/history.html#v59-1-0) - And we then upgraded to `setuptools` 59.2.0 in commit 1adb70d We do not depend on `packaging` at all, it was a pin of a transitive build dependency. So let's clean it up. Tested locally as well with `python -m build --wheel` (which uses `pyproject.toml` to build a wheel in an isolated venv), and then checking the wheel tags and ensuring the wheel can be installed with Pip. [ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a build issue on numpy with M1:
AssertionError: would build wheel with unsupported tag ('cp39', 'cp39', 'macosx_11_0_universal2')
The issue was fixed in the packaging 20.5 and onwards, but that was not
getting picked by setuptools. So explicitly adding this dependency in
the toml file. The change was tested with: