BUG: don't mutate list of fake libraries while iterating over it.#18326
Merged
charris merged 1 commit intonumpy:maintenance/1.20.xfrom Feb 4, 2021
Merged
BUG: don't mutate list of fake libraries while iterating over it.#18326charris merged 1 commit intonumpy:maintenance/1.20.xfrom
charris merged 1 commit intonumpy:maintenance/1.20.xfrom
Conversation
…py#18295) * BUG: don't mutate list of fake libraries while iterating over it * BUG: iterate over copy of list * TST: add build test for build_ext fix (#1) * TST: add build test for build_ext fix * TST: clearer test name * STY: use triple quotes instead of lists of strings * FIX: check for f77 compiler before test is run * DOC: add comment explaining that a list copy is necessary
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #18295.
BUG: don't mutate list of fake libraries while iterating over it
BUG: iterate over copy of list
TST: add build test for build_ext fix (Misc #1)
TST: add build test for build_ext fix
TST: clearer test name
STY: use triple quotes instead of lists of strings
FIX: check for f77 compiler before test is run
DOC: add comment explaining that a list copy is necessary