ENH: add support for fujitsu compiler to numpy.#17792
Conversation
|
Isn't this the Lahey/Fujitsu compiler already supported in |
|
@rgommers
No, it's different from the lahey/fujitsu compiler. |
rgommers
left a comment
There was a problem hiding this comment.
No, it's different from the lahey/fujitsu compiler.
The new compiler registered is developed by Fujitsu and is used in A64FX on Fugaku.
Thanks, that helps. Could you add this info to the docstring of the file? Including a link to the current best source of information about it?
There is currently no HP that introduces this compiler.
That doesn't preclude inclusion here I think; there's no other good way to add compiler support and it's very low-overhead so I'm fine with merging this.
One question out of interest - if frt going to stay? Based on this article I'd expect gfortran support too, which may then become the default?
OK, I will add docstring to 'fujitsu.py'.
As you say, we can use the gcc compiler on Fugaku, but we recommend using the Fujitsu compiler to maximize the performance of fugaku. I just agree to support fugaku's gfortran in numpy. |
That makes sense.
Sounds good, thank you. |
rgommers
left a comment
There was a problem hiding this comment.
LGTM now, merging. Thanks @t-karatsu
|
Thanks for merge! |
|
@t-karatsu this PR added compiler support but performance is still poor because the fujitsu linear algebra library is not detected. Of course, one can build e.g. openblas with the fujitsu compiler and it get's better, but it would be better to use the fujitsu linear algebra library, no? As I understand it, it's always (?) bundled with the compiler? The patch in https://gist.github.com/migueldiascosta/3bf319b9eecd888957db50933d2d701f worked for me at Fugaku, and performance is indeed better - is this something you've worked on and/or are interested in testing/reviewing? |
Hello, this is my first post.
If I need to do something else about submitting PR, please let me know.
I would like to add support for Fujitsu compiler to numpy, so submitted the necessary changes.
Could you check if there are any questions or areas that need to be corrected?