BUG: relpath fails for different drives on windows #16308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any reason to not just change this on all platforms? |
Member
Author
Let's give it a try |
Member
|
We could switch to a more conservative implementation after a release of 1.20rc1 or something |
Member
Author
|
Builds are green. Anyone want to take a look and merge it to unblock the CI failures? |
Member
|
Green is good, merging to stop the bleeding. |
Member
|
Labeled for backport, azure was also failing on 1.19.x. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
May 20, 2020
* BUG: relpath fails for different drives on windows * ENH: always use abspath
charris
pushed a commit
to charris/numpy
that referenced
this pull request
May 30, 2020
* BUG: relpath fails for different drives on windows * ENH: always use abspath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive gh-12535. Fixes gh-12530. Sorry, no test.
This PR should fix the immediate problem of broken CI runs or smoke out the reason
relpathwas used in the first place.