BUG: Respect itershape=() in nditer#15885
Merged
mattip merged 2 commits intonumpy:masterfrom Apr 1, 2020
Merged
Conversation
cfcaddc to
f2f6c7b
Compare
Previously this was treated as itershape=None, which meant something else. The docstring was added only a handful of commits ago, so it shouldn't matter that the documented default "changed".
f2f6c7b to
5ae9f65
Compare
seberg
approved these changes
Mar 31, 2020
Member
seberg
left a comment
There was a problem hiding this comment.
Going to reformat the long lines and then merge, thanks (assuming I am getting it right with the suggestion commiting :)).
Member
|
Thanks @eric-wieser , @seberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was treated as itershape=None, which meant something else.
The docstring was added only a handful of commits ago, so it shouldn't matter that the documented default "changed".
Good catch @seberg, you were right about the default in #15877.
Thanks for opening this can of worms.
More like gh-15881 and gh-15882