BUG: Do not ignore empty tuple of strides in ndarray.__new__#15882
Merged
mattip merged 2 commits intonumpy:masterfrom Mar 31, 2020
Merged
BUG: Do not ignore empty tuple of strides in ndarray.__new__#15882mattip merged 2 commits intonumpy:masterfrom
mattip merged 2 commits intonumpy:masterfrom
Conversation
mattip
reviewed
Mar 31, 2020
d1d2f1d to
25461c5
Compare
Member
|
Since this is a change in behaviour from 1.17, maybe it should have a release note? |
Previously this was treated as though an empty set of strides were passed. Now this is treated as a request for `.strides == ()`.
Member
Author
|
Can't hurt, added a release note |
25461c5 to
b88415e
Compare
Member
|
Thanks @eric-wieser |
This was referenced Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this was treated as though an empty set of strides were passed.
Now this is treated as a request for
.strides == ().First commit is shared with #15881