MAINT: Improve const-correctness of shapes and strides#15251
Merged
mattip merged 1 commit intonumpy:masterfrom Jan 6, 2020
Merged
MAINT: Improve const-correctness of shapes and strides#15251mattip merged 1 commit intonumpy:masterfrom
mattip merged 1 commit intonumpy:masterfrom
Conversation
e65f073 to
bb22373
Compare
Marking these arguments as const makes it easier to reason about these functions, and prevent accidental mutation. The C99 standard (6.2.5/26 "Types") guarantees that ABI compatibility is preserved here.
bb22373 to
c2501e4
Compare
Member
|
Thanks @eric-wieser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAINT: Improve const-correctness of shapes and strides
Marking these arguments as const makes it easier to reason about these functions, and prevent accidental mutation.
The C99 standard (6.2.5/26 "Types") guarantees that ABI compatibility is preserved here.
The only parts of the public API affected are:
PyArray_BroadcastToShapePyArray_IntTupleFromIntpPyArray_OverflowMultiplyListAll of which will now accept
npy_intp const*dimensions, which is backwards compatible.Somewhat continues from gh-14484.
Restricted to things of type
npy_intpto keep the size of this patch under control.Left out from this patch is #15252, which would impact downstream compiler warnings.