-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
Closed
Labels
03 - Maintenance63 - C APIChanges or additions to the C API. Mailing list should usually be notified.Changes or additions to the C API. Mailing list should usually be notified.
Description
Today, the ufunc loop signature (PyUFuncGenericFunction) is
Line 844 in 3883be3
| ctypedef void (*PyUFuncGenericFunction) (char **, npy_intp *, npy_intp *, void *) |
I would argue it should be (char **, npy_intp const *, npy_intp const*, void *), ie inner loops are not allowed to modify the shape or stride.
Changing this would force users to either:
- Ignore compiler warnings
- Add
constto their loop signatures
Creating this issue now so that I can reference it internally.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
03 - Maintenance63 - C APIChanges or additions to the C API. Mailing list should usually be notified.Changes or additions to the C API. Mailing list should usually be notified.