ENH: Add support for building with clang-cl by bashtage · Pull Request #13816 · numpy/numpy

bashtage · 2019-06-21T13:55:26Z

Add support for clang-cl on Windows

NumPy builds and passes with clang-cl.

Is this a worthwhile effort? Is it useful? I have found clang-cl to be very helpful in some situations where MSVC won't produce decent code.
Are there a lot of MSVC-specific changes that need to be checked?
If this goes forward, should there be a CI build with it?
Need to check x86 as well.
Does this need to go to the mailing list?

charris · 2019-06-23T14:46:01Z

I think this is useful, I have hopes that clang will eventually give us opensource C and Fortran compilers for windows, especially the latter.

numpy/distutils/ccompiler.py

mattip · 2019-07-07T00:14:08Z

Can you compile cpython with clangcl on windows? I am a bit surprised we need to add our own ClangCL class to distutils.

It would indeed be useful to set up a windows CI run under 32-bit and 64-bit for this.

bashtage · 2019-07-07T08:10:08Z

Can you compile cpython with clangcl on windows? I am a bit surprised we need to add our own ClangCL class to distutils.

There is an open ticket with a patch to allow it to build: https://bugs.python.org/issue33351

This said, distutils doesn't support clang-cl any more than distutils supports icc on windows. It is unfortunate that commands like CC={cl|icl|clang-cl} python setup.py develop don't work Windows like that do on Unix.

AKAICT this is why NumPy would need to directly support clang-cl (if it is a good idea).

mattip · 2019-07-16T14:49:58Z

How would this play out for clang on linux, since the new class is windows-specific?

bashtage · 2019-07-16T14:57:50Z

clang on unix is trivial since you can use cc=clang python setup.py install. Windows doesn't honor cc variables.

mattip · 2019-07-16T15:03:04Z

What is the magical incantation to get runtests.py or setup.py to use clang on windows?

bashtage · 2019-07-16T15:05:57Z

I used the same trick that is used for icc

python setup.py config --compiler=clang-cl build_clib --compiler=clang-cl build_ext --compiler=clang-cl install

See https://software.intel.com/en-us/articles/numpyscipy-with-intel-mkl

bashtage · 2019-07-16T15:06:16Z

It is likely that I'm not doing it correctly.

mattip · 2019-09-17T15:11:11Z

build already accepts a compiler option and passes it on to the sub-commands, so it should be sufficient to run setup.py build --compiler=clang-cl. We could add a --compiler option to runtests.py that would get passed on to build

bashtage · 2019-09-17T16:06:43Z

That would probably help. I think clang-cl might still need a few settings since it isn't 100% identical to cl.

serge-sans-paille · 2019-12-03T08:28:00Z

@bashtage : I <3 that PR. If you're interested in extra tests, I can launch the full pythran recompilation based on this, we are in great need for such support, and currently rely on a dirty hack for clang-cl support.

bashtage · 2019-12-03T14:22:24Z

I would like to finish this in the next month or so. Needs a good bit of cleaning I think.

h-vetinari · 2020-01-26T18:06:15Z

Any news on this PR? :)

h-vetinari · 2020-05-28T12:46:02Z

I hope another ping 4 months later does not constitute bad form. 😉

bashtage · 2020-05-29T10:50:09Z

@mattip I've updated to reflect changes and this is working. I have also improved it. Any idea how I could take this forward?

bashtage · 2020-05-29T16:26:57Z

I think it is there, although ideally it would get a CI run.

python runtests.py --compiler=clang-cl
.....................................................................................
.....................................................................................
.....................................................................................
10394 passed, 454 skipped, 108 deselected, 17 xfailed, 1 xpassed in 73.10s (0:01:13)

Add support for clang-cl on Windows

Fix compiler for recent changes in NumPy

Add support for --compiler in run tests

Clarify methods to build or test

Make definition and implementation match exactly for clang-cl compat

Forbid compiling 32 with 64 bit clang-cl and vice versa Link against built-ins on 32-bit platforms Improve formatting and add comments

Correct == incorrectly changed to not in

Co-authored-by: Matti Picus <matti.picus@gmail.com>

Fix for inlining issue Try lld-link

Add optimization Revert changes for warnings awaiting numpy#18432 Small clean up of commented code

_udiv128 is not available in clang-cl Revert change from llabs to labs

Cast to silence warning Fix type in compiler_type check

Remove check which isn't needed when calling setup with arguments in the correct order

Port over changes needed to compile NumPy using clang-cl from numpy#13816. Desirable to retain these even though distutils is effectively deprecated and so not worth the effort to alter.

Bug continues on clang-cl

InessaPawson · 2022-02-28T17:58:54Z

Do we wish to continue working on this PR, given numpy.distutils has been officially deprecated?

bashtage · 2022-02-28T18:19:11Z

The PR is eol. I think the good parts all got merged in other PRs.

mattip · 2022-03-01T03:41:36Z

Let's close this

charris added 01 - Enhancement component: numpy.distutils labels Jun 21, 2019

bashtage mentioned this pull request Jun 24, 2019

Complex math errors compiling under clang 5 / Windows #8768

Closed

mattip reviewed Jul 7, 2019

View reviewed changes

numpy/distutils/ccompiler.py Outdated Show resolved Hide resolved

mattip mentioned this pull request Oct 7, 2019

BUILD: change to build_src --verbose-cfg, runtests.py --debug-info #14630

Merged

rgommers mentioned this pull request Dec 3, 2019

Optional Pythran support for scipy.signal.max_len_seq_inner scipy/scipy#8306

Merged

serge-sans-paille mentioned this pull request May 20, 2020

Linker overwritten on windows with clang-cl.exe and distutils causing link failure serge-sans-paille/pythran#1521

Closed

bashtage force-pushed the clang-windows-build branch from 5f1d7dc to 6b0aab5 Compare May 28, 2020 21:27

bashtage force-pushed the clang-windows-build branch 5 times, most recently from ac28f73 to c79ee85 Compare May 29, 2020 16:25

bashtage changed the title ~~WIP/ENH: Add support for building with clang-cl~~ ENH: Add support for building with clang-cl May 29, 2020

bashtage force-pushed the clang-windows-build branch from eb7c496 to d3f06a2 Compare November 19, 2021 11:08

bashtage force-pushed the clang-windows-build branch from d3f06a2 to 47c0516 Compare November 30, 2021 08:07

bashtage and others added 20 commits January 20, 2022 18:06

ENH: Add support for building with clang-cl

1f45e79

Add support for clang-cl on Windows

MAINT: Update clang-cl compiler

80abc24

Fix compiler for recent changes in NumPy

ENH: Allow compiler to be set in runtests

5f0f2c6

Add support for --compiler in run tests

DOC: Improve instructions for building

2759321

Clarify methods to build or test

MAINT: Make definition match exactly

d884e11

Make definition and implementation match exactly for clang-cl compat

DOC: Add a release note

ddc912a

BUG: Block compiling across bitness

166cc68

Forbid compiling 32 with 64 bit clang-cl and vice versa Link against built-ins on 32-bit platforms Improve formatting and add comments

TST: Add Clang build to Azure

34a9b64

BUG: Allow clang-cl to sub for msvc

b8bf43f

Correct == incorrectly changed to not in

MAINT: Rename clang_cl -> clang-cl

d4f0ea3

Co-authored-by: Matti Picus <matti.picus@gmail.com>

BUG: Fix inlining issue

e4640c6

Fix for inlining issue Try lld-link

CLN: Clean up issues creating warnings

c48d788

ENH: Add clang-cl optimization

0aae3c6

Add optimization Revert changes for warnings awaiting numpy#18432 Small clean up of commented code

MAINT: Remove _udiv128 from clang-cl path

ffb2a28

_udiv128 is not available in clang-cl Revert change from llabs to labs

MAINT: Reduce warnings

759e9ce

Cast to silence warning Fix type in compiler_type check

CLN: Improve comments and resolve small issues

8422693

MAINT: Remove hasattr check

e326c15

Remove check which isn't needed when calling setup with arguments in the correct order

BUG: Remove inline decorator from shared function

471f02b

Fix distributor init

0acd057

Continue to work on issues in Clang-cl

1cb41db

bashtage force-pushed the clang-windows-build branch from 47c0516 to 4c31368 Compare January 20, 2022 18:08

bashtage mentioned this pull request Jan 20, 2022

ENH: Add changes that allow NumPy to compile with clang-cl #20866

Merged

bashtage force-pushed the clang-windows-build branch from 4c31368 to b445c57 Compare January 20, 2022 18:17

BUG: Use workaround on clang-cl

df97b04

Bug continues on clang-cl

Uh oh!

Conversation

bashtage commented Jun 21, 2019 • edited by rgommers Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

charris commented Jun 23, 2019

Uh oh!

Uh oh!

mattip commented Jul 7, 2019

Uh oh!

bashtage commented Jul 7, 2019

Uh oh!

mattip commented Jul 16, 2019

Uh oh!

bashtage commented Jul 16, 2019

Uh oh!

mattip commented Jul 16, 2019

Uh oh!

bashtage commented Jul 16, 2019

Uh oh!

bashtage commented Jul 16, 2019

Uh oh!

mattip commented Sep 17, 2019

Uh oh!

bashtage commented Sep 17, 2019

Uh oh!

serge-sans-paille commented Dec 3, 2019

Uh oh!

bashtage commented Dec 3, 2019

Uh oh!

h-vetinari commented Jan 26, 2020

Uh oh!

h-vetinari commented May 28, 2020

Uh oh!

bashtage commented May 29, 2020

Uh oh!

bashtage commented May 29, 2020

Uh oh!

InessaPawson commented Feb 28, 2022

Uh oh!

bashtage commented Feb 28, 2022

Uh oh!

mattip commented Mar 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

bashtage commented Jun 21, 2019 •

edited by rgommers

Loading