Businessday make np.busday_count return negative values when the start date is after end date#117
Closed
gandalf013 wants to merge 2 commits intonumpy:masterfrom
Closed
Businessday make np.busday_count return negative values when the start date is after end date#117gandalf013 wants to merge 2 commits intonumpy:masterfrom
gandalf013 wants to merge 2 commits intonumpy:masterfrom
Conversation
Member
|
The change looks good, I've gone ahead and merged it. I updated the documentation and tests as well, to complete it. |
luyahan
pushed a commit
to plctlab/numpy
that referenced
this pull request
Apr 25, 2024
test: Add new file debug_tools.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.busday_count() returns 0 if start date is after end date. This patch fixes it to return negative values in this case.