Skip to content

BUG: Resize bytes_ columns in genfromtxt#10401

Merged
charris merged 1 commit intonumpy:masterfrom
eric-wieser:fix-10394
Feb 7, 2018
Merged

BUG: Resize bytes_ columns in genfromtxt#10401
charris merged 1 commit intonumpy:masterfrom
eric-wieser:fix-10394

Conversation

@eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jan 14, 2018

Fixes gh-10394, due to regression in gh-10054

Backportable here

@eric-wieser eric-wieser added this to the 1.14.1 release milestone Jan 14, 2018
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what this is testing for, but these lines are just cleanup anyway, now that typestr is consistent with column_types

@eric-wieser eric-wieser force-pushed the fix-10394 branch 2 times, most recently from 3074a04 to 3251f10 Compare January 15, 2018 17:27
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this should have been 'S4' after all...

@charris charris merged commit 12668b6 into numpy:master Feb 7, 2018
charris added a commit that referenced this pull request Feb 7, 2018
BUG: Resize bytes_ columns in genfromtxt (backport of #10401)
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible regression with numpy 1.14.0 and recfromcsv

2 participants