Add support for Python 3.12#130
Conversation
d11473b to
c5614bd
Compare
.github/workflows/umbral-pre.yml
Outdated
| - "3.10" | ||
| - "3.12" | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Side note: the versions of some of these dependent actions should be updated:
- checkout: v4
- setup-python: v4
- download-artifact: v3
...
We can either update these as part of this PR or another one (with issue tracking), but we should update them.
.github/workflows/umbral-pre.yml
Outdated
| - stable | ||
| python: | ||
| - "3.10" | ||
| - "3.12" |
There was a problem hiding this comment.
AFAIK this gh action builds and runs tests (please correct me if I'm mistaken), so if we are claiming to support 3.8 all the way up to 3.12, should this python definition actually be a matrix with value ["3.8", "3.12"] instead of a single python version.
Basically, I'm worried about us simply building & testing with 3.12 and then claiming we support older versions. eg. if we add a python 3.12 specific feature, that isn't compatible with older version of python, then the build/test can pass but we aren't actually supporting older versions.
I know that internally we are the only real users of rust-umbral, but it is published separately - so it's good to be consistent with what the library claims to support.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 58.11% 58.11%
=======================================
Files 17 17
Lines 3123 3123
=======================================
Hits 1815 1815
Misses 1308 1308 ☔ View full report in Codecov by Sentry. |
51da91a to
8017f6f
Compare
Type of PR:
Required reviews:
Issues fixed/closed: