Skip to content

Indicate support for python 3.12#87

Merged
piotr-roslaniec merged 1 commit intonucypher:mainfrom
KPrasch:main
Nov 30, 2023
Merged

Indicate support for python 3.12#87
piotr-roslaniec merged 1 commit intonucypher:mainfrom
KPrasch:main

Conversation

@KPrasch
Copy link
Copy Markdown
Member

@KPrasch KPrasch commented Nov 3, 2023

No description provided.

@KPrasch KPrasch marked this pull request as ready for review November 3, 2023 14:26
Copy link
Copy Markdown
Contributor

@piotr-roslaniec piotr-roslaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need that? We should probably update ferveo too

@derekpierre
Copy link
Copy Markdown
Member

Same question as @piotr-roslaniec - is there a reason to support 3.12 before launch? Either way nucypher only states that it supports up to python 3.11 at the moment.

If intended for like a 7.1.0 - we can create a 7.1.0 branch in nucypher-core if you like.

Copy link
Copy Markdown
Member Author

@KPrasch KPrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nucypher-core is already compatible with python 3.12 without additional changes so this is more of a maintenance formality. It will still be possible to use nucypher-core-python with python 3.8 if this PR is merged.

That being said, there are noteworthy performance optimizations in python 3.12 that nodes can benefit from. The largest consumers and primary audience of the nucypher/nucypher repo will launch nodes with docker, which we can ship against python 3.12 instead of 3.8. By pre-building python wheels for 3.12 instead of 3.8 in this PR we optimize the newest version of python for the fastest install.

Additionally, python 3.8 is around 10 months away from EOL (in fact active support ceased two years ago).

@KPrasch
Copy link
Copy Markdown
Member Author

KPrasch commented Nov 3, 2023

Either way nucypher only states that it supports up to python 3.11 at the moment.

Also see nucypher/nucypher#3327

@piotr-roslaniec
Copy link
Copy Markdown
Contributor

Bumped Python version in ferveo: nucypher/ferveo@608cddc

@piotr-roslaniec
Copy link
Copy Markdown
Contributor

We should probably do the same for umbral?

@piotr-roslaniec
Copy link
Copy Markdown
Contributor

Created nucypher/rust-umbral#130

Copy link
Copy Markdown
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@piotr-roslaniec piotr-roslaniec merged commit 622b8c3 into nucypher:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants