General repo improvements#109
Conversation
eef8522 to
2a57578
Compare
| assert event["startTimestamp"] == start | ||
| assert event["endTimestamp"] == end | ||
| assert event["cost"] == fee | ||
| assert tx.events == [ |
There was a problem hiding this comment.
love this way of checking events 🚀
| _precomputed.pointEZyCoord | ||
| ), // zE_y |
There was a problem hiding this comment.
Minor suggestion where I disagree with the linter.
| _precomputed.pointEZyCoord | |
| ), // zE_y | |
| _precomputed.pointEZyCoord // zE_y | |
| ), |
Some similar instances in later lines in this file.
There was a problem hiding this comment.
Looks like there is open issue in prettier for that prettier/prettier#807
We can add hack for ignoring this line for prettier or just accept that. Wdyt?
There was a problem hiding this comment.
Not a huge issue to me. If the hack is easy great, if it's more involved, don't bother. Up to you really.
| assert event["stakingProvider"] == staking_provider | ||
| assert event["fromAmount"] == 0 | ||
| assert event["toAmount"] == value | ||
| assert events == [ |
| uint256 constant PRECOMPUTED_DATA_SIZE = (20 * BIGNUM_SIZE) + 32 + 20 + 5; | ||
| uint256 internal constant BIGNUM_SIZE = 32; | ||
| uint256 internal constant POINT_SIZE = 33; | ||
| uint256 internal constant SIGNATURE_SIZE = 64; |
| assert event["fromAmount"] == value // 2 | ||
| assert event["toAmount"] == authorization | ||
| assert events == [ | ||
| taco_application.AuthorizationInvoluntaryDecreased( |
There was a problem hiding this comment.
badass. Love seeing events represented this way.
jMyles
left a comment
There was a problem hiding this comment.
As always, some of the nitty-gritty of solidity is a little tough for me to gork quickly, but I can verify that there's nothing here that looks crazy. :-)
Uh oh!
There was an error while loading. Please reload this page.