Casual Alice with Policy and Payment Defaults by KPrasch · Pull Request #984 · nucypher/nucypher

KPrasch · 2019-05-17T01:32:45Z

What this does

Follow up for [EPIC] Decentralized Characters & Integrated Ethereum Node Providers #951
Decentralized Grant
Save / Load policy defaults for M, N, duration and value on-disk via AliceConfiguration
Allow policy defaults to be used or overridden on Alice APIs
Use the CLI to initialize and run an Alice using an internally managed geth process (--geth)
Use a common function for making CLI characters (reduces character CLI length)
Removes policy mocking from decentralized grant testing
Decentralized test_cli_lifecycle test
checksum_public_address -> checksum_address
Introduces Agency metaclass (makes agent subclasses singletons)
Style and convention improvements for character CLI modules

Examples


# Configure a new persistent Alice with an integrated geth node
# using recommended testnet defaults, Save chain syncing for later.
$ nucypher alice init --geth --no-sync

# Run an Alice IPC Control Server using an integrated geth node
$ nucypher alice run --geth

# Use default M, N, and Rate to Grant
$ nucypher alice grant --geth --bob-encrypting-key ... --bob-verifying-key ... --label ...

Fixes #975
Fixes #1015

codecov · 2019-06-04T19:45:46Z

Codecov Report

Merging #984 into master will decrease coverage by 3.29%.
The diff coverage is 73.3%.

@@            Coverage Diff            @@
##           master     #984     +/-   ##
=========================================
- Coverage   83.19%   79.89%   -3.3%     
=========================================
  Files          67       67             
  Lines        8663     8754     +91     
=========================================
- Hits         7207     6994    -213     
- Misses       1456     1760    +304

Impacted Files	Coverage Δ
nucypher/characters/unlawful.py	`96.55% <ø> (ø)`	⬆️
nucypher/blockchain/eth/chains.py	`74.07% <ø> (ø)`	⬆️
nucypher/config/characters.py	`98.97% <100%> (+0.22%)`	⬆️
nucypher/blockchain/eth/token.py	`89.78% <100%> (ø)`	⬆️
nucypher/utilities/sandbox/ursula.py	`98.07% <100%> (ø)`	⬆️
nucypher/network/server.py	`85.18% <100%> (-2.78%)`	⬇️
nucypher/cli/deploy.py	`69.39% <100%> (ø)`	⬆️
nucypher/cli/processes.py	`72.85% <100%> (ø)`	⬆️
nucypher/config/constants.py	`100% <100%> (ø)`	⬆️
nucypher/crypto/powers.py	`92.24% <100%> (-2.59%)`	⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9330e69...80057d8. Read the comment docs.

…ocess

nucypher/blockchain/eth/clients.py

nucypher/blockchain/eth/policies.py

nucypher/characters/chaotic.py

nucypher/characters/lawful.py

nucypher/config/node.py

cygnusv · 2019-06-07T16:43:23Z

Two questions:

Do you want to merge this on master or on [EPIC] Alhambra Verde - Introduce Staker and Worker Roles #1029?
Was there a consensus on changing checksum_public_address to checksum_address? It doesn't seem as something critical. Also, I'm not a big fan that this type of renames that impact dozens of files are part of bigger PRs. Now there will be lots of conflicts for all the in-parallel work done in other branches.

… tests.

…CLI init command.

…ontroller ports

Co-Authored-By: David Núñez <david@nucypher.com> Co-Authored-By: Derek Pierre <derek.pierre@gmail.com>

…r#1015 - BlockchainPolicy value must be greater than 0.

… collection test

…roves depth of reward collection integration testing

derekpierre · 2019-06-09T13:54:53Z

nucypher/config/node.py

+                # "Formal Geth" - Manual Web3 Provider, We assume is already running and available
+                else:
+                    self.connect_to_blockchain()
+                    if not self.blockchain.interface.client.accounts:


cygnusv

💯

cygnusv · 2019-06-09T19:36:27Z

nucypher/blockchain/eth/actors.py

    def is_staking(self) -> bool:
        """Checks if this Miner currently has active stakes / locked tokens."""
-        return bool(self.locked_tokens > NU.ZERO())
+        return bool(self.stakes)


Just curious: why bool(self.stakes) is the response here? What's the underlying logic?

self.__read_stakes() # "load-in": Read on-chain stakes "syncs" the onchain stakes into the local staking cache on Staker, and self.stakes will be set to NO_STAKES.bool_value(False) if there are no active stakes.

cygnusv · 2019-06-09T19:38:26Z

nucypher/characters/control/specifications.py

 class AliceSpecification(CharacterSpecification):

-    __create_policy = (('bob_encrypting_key', 'bob_verifying_key', 'm', 'n', 'label'),  # In
+    __create_policy = (('bob_encrypting_key', 'bob_verifying_key', 'm', 'n', 'label', 'expiration'),  # In


How can we handle conditionally-required inputs in specifications? In this case, value is mandatory when not federated. Seems kind of tricky to do it.

Good eye! I've been thinking about this too, I think it's possible to allow values to be passed as None all the way into character, with some modification to specification handling seen here.

It might second Issue, but here's one #1065

Co-Authored-By: David Núñez <david@nucypher.com> Co-Authored-By: Derek Pierre <derek.pierre@gmail.com>

Casual Alice with Policy and Payment Defaults

KPrasch changed the base branch from master to hawksbeard May 17, 2019 01:32

KPrasch changed the title ~~Casual geth~~ Alice's Casual geth with payment May 17, 2019

KPrasch changed the title ~~Alice's Casual geth with payment~~ Alice's Casual geth with payment defaults May 17, 2019

KPrasch force-pushed the hawksbeard branch from 0c9d60a to d11f497 Compare May 27, 2019 14:38

KPrasch force-pushed the casual-geth branch from abc5b9b to 0273b96 Compare May 31, 2019 22:11

KPrasch force-pushed the hawksbeard branch 2 times, most recently from 7ba150a to b6ba1ff Compare June 3, 2019 19:56

KPrasch mentioned this pull request Jun 3, 2019

[EPIC] Decentralized Characters & Integrated Ethereum Node Providers #951

Merged

20 tasks

KPrasch force-pushed the casual-geth branch from 0273b96 to 42734b9 Compare June 4, 2019 19:45

KPrasch self-assigned this Jun 4, 2019

KPrasch added 2 commits June 5, 2019 09:16

Casual Alice Geth and moving towards testnet as a default provider pr…

e32aab1

…ocess

working towards default Alice cryptoeconomics values during grant

2f5e514

KPrasch force-pushed the casual-geth branch from 13700df to c3a5fdb Compare June 5, 2019 16:19

KPrasch added Alice 👩 Effects the "Alice" development area Configuration Node configuration labels Jun 5, 2019

This was referenced Jun 5, 2019

Provide predefined set of options for m-of-n #853

Closed

ISO8601 datetime format has a variable length, we expect constant length #906

Closed

KPrasch changed the base branch from hawksbeard to master June 6, 2019 19:07

KPrasch changed the title ~~Alice's Casual geth with payment defaults~~ Casual Alice with Policy and Payment Defaults Jun 6, 2019

KPrasch requested review from cygnusv, derekpierre, fjarri, jMyles, michwill, tuxxy and vepkenez June 6, 2019 20:18

KPrasch marked this pull request as ready for review June 6, 2019 20:19

derekpierre reviewed Jun 7, 2019

View reviewed changes

KPrasch and others added 14 commits June 8, 2019 14:26

Testing decentralized grant, Adds missing datetime to policy creation…

f90cc45

… tests.

Generic and specific character configuration testing

c077db8

Remove expiration date from create policy entry points

3bfc7aa

Alice restores default policy values from configuration file

459bc03

Refining blockchian sync management for internal geth processes

9430997

Restores skipped stake division test on MinerAgent

cf64e5f

Alice view command is a little more eager.

c6ca78e

Creating a code path for... Bob. Aviods ethereum client logic during …

c83fa75

…CLI init command.

Use a common bootstrapping function for making cli characters

098e0f4

Gives PolicyAuthor an economics instance

8b244c9

Passing decentralized grant CLI lifecycle test

807ffd3

Thin out web3 client syncing, Use configuration classes for default c…

cc34540

…ontroller ports

Accept alice configuration policy defaults at init-time by CLI flags.

dfbbba4

Respond to RFCs in PR nucypher#984; Apply suggestions from code review

d743e3b

Co-Authored-By: David Núñez <david@nucypher.com> Co-Authored-By: Derek Pierre <derek.pierre@gmail.com>

KPrasch force-pushed the casual-geth branch from 7f8e0e3 to b9d4543 Compare June 8, 2019 22:16

Cleanup policy and arrangement value code paths - Fixes Issue nucyphe…

f643f3a

…r#1015 - BlockchainPolicy value must be greater than 0.

KPrasch force-pushed the casual-geth branch from b9d4543 to f643f3a Compare June 8, 2019 22:35

KPrasch added 3 commits June 8, 2019 20:21

Style and convention improvements found while debugging failed reward…

e43ba62

… collection test

Fixes miscalculated first period reward rate (See nucypher#1063), Imp…

9e96b11

…roves depth of reward collection integration testing

Sanity checks for testerchain

80057d8

KPrasch requested a review from cygnusv June 9, 2019 03:31

derekpierre reviewed Jun 9, 2019

View reviewed changes

derekpierre approved these changes Jun 9, 2019

View reviewed changes

cygnusv approved these changes Jun 9, 2019

View reviewed changes

KPrasch merged commit fab5b63 into nucypher:master Jun 9, 2019

cygnusv added a commit that referenced this pull request Jun 10, 2019

Respond to RFCs in PR #984; Apply suggestions from code review

6129dcf

Co-Authored-By: David Núñez <david@nucypher.com> Co-Authored-By: Derek Pierre <derek.pierre@gmail.com>

cygnusv pushed a commit that referenced this pull request Jun 10, 2019

Merge pull request #984 from KPrasch/casual-geth

f5d7434

Casual Alice with Policy and Payment Defaults

cygnusv pushed a commit that referenced this pull request Jun 11, 2019

Merge pull request #984 from KPrasch/casual-geth

d5eb99a

Casual Alice with Policy and Payment Defaults

KPrasch mentioned this pull request Jun 14, 2019

Decentralized Character Control (Alice) #844

Closed

KPrasch deleted the casual-geth branch July 21, 2020 02:31

Conversation

KPrasch commented May 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this does

Examples

Uh oh!

codecov bot commented Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cygnusv commented Jun 7, 2019

Uh oh!

derekpierre Jun 9, 2019

Choose a reason for hiding this comment

Uh oh!

cygnusv left a comment

Choose a reason for hiding this comment

Uh oh!

cygnusv Jun 9, 2019

Choose a reason for hiding this comment

Uh oh!

KPrasch Jun 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cygnusv Jun 9, 2019

Choose a reason for hiding this comment

Uh oh!

KPrasch Jun 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KPrasch Jun 9, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KPrasch commented May 17, 2019 •

edited

Loading

codecov bot commented Jun 4, 2019 •

edited

Loading

KPrasch Jun 9, 2019 •

edited

Loading

KPrasch Jun 9, 2019 •

edited

Loading