Grant & Retrieve via Polygon Payments; Pre-release cleanup.#2873
Grant & Retrieve via Polygon Payments; Pre-release cleanup.#2873KPrasch merged 19 commits intonucypher:mainfrom
Conversation
22c252d to
84eb6b3
Compare
|
@KPrasch what's needed to get this off of WIP? |
|
First off the dependencies were updated which resulted in new test failures so we'll need to resolve that. Ideally this can be followed up with the complete relocation of contract tests to nucypher-contracts to lessen the impact of SubscriptionManager updates. |
db3f764 to
ada4435
Compare
8b4ac6e to
ae41eec
Compare
…d ursulas, and polygon payments.
… pre application.
|
|
||
| if not publisher_verifying_key: | ||
| publisher_verifying_key = alice_verifying_key | ||
| publisher_verifying_key = PublicKey.from_bytes(bytes(publisher_verifying_key)) |
There was a problem hiding this comment.
I remember removing a line like that :) How do bytes turn up so deep in the call stack?
There was a problem hiding this comment.
Heh - I had the same thought. I think it's coming from here https://github.com/nucypher/nucypher/blob/main/examples/finnegans_wake_demo/finnegans-wake-demo-testnet-l2.py#L106
There was a problem hiding this comment.
The demo code is fixed now, right? If so, is this still necessary - the type hint for the function is that publisher_verifying_key should be provided as PublicKey so providing bytes does not adhere to the API - unless we are worried about something else...?
There was a problem hiding this comment.
Let's revisit this issue in a future PR. Other than some negligible inefficiency I don't think there's any negative impact of accepting bytes or a public key here.
derekpierre
left a comment
There was a problem hiding this comment.
Also created PR into airship to improve consistency in the external ip utilities unit test - KPrasch#36.
|
|
||
| if not publisher_verifying_key: | ||
| publisher_verifying_key = alice_verifying_key | ||
| publisher_verifying_key = PublicKey.from_bytes(bytes(publisher_verifying_key)) |
There was a problem hiding this comment.
The demo code is fixed now, right? If so, is this still necessary - the type hint for the function is that publisher_verifying_key should be provided as PublicKey so providing bytes does not adhere to the API - unless we are worried about something else...?
|
🤠 Merging -- Thanks for the contributions! |
|
YES! |
|
Yay ! Nice work guys |
Type of PR:
Bugfix & Feature
Required reviews:
2
What this does:
NUCYPHER_WORKER_ETH_PASSWORD->NUCYPHER_OPERATOR_ETH_PASSWORD