Merged
Conversation
fjarri
reviewed
Jul 9, 2021
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Jul 13, 2021
fjarri
reviewed
Jul 14, 2021
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Jul 15, 2021
KPrasch
added a commit
to KPrasch/nucypher
that referenced
this pull request
Jul 15, 2021
piotr-roslaniec
approved these changes
Jul 16, 2021
cygnusv
reviewed
Jul 26, 2021
| option_force = click.option('--force', help="Don't ask for confirmation", is_flag=True) | ||
| option_gas_price = click.option('--gas-price', help="Set a static gas price (in GWEI)", type=GWEI) | ||
| option_gas_strategy = click.option('--gas-strategy', help="Operate with a specified gas price strategy", type=click.STRING) # TODO: GAS_STRATEGY_CHOICES | ||
| option_key_material = click.option('--key-material', help="A pre-secured hex-encoded secret to use for private key derivations", type=click.STRING) |
Member
There was a problem hiding this comment.
Instead of directly inputting the key material here, an alternative is to pass a file path that contains the key material. The advantage here is not disclosing the key material from the shell history. Geth does something similar for passwords (see https://geth.ethereum.org/docs/interface/managing-your-accounts)
Member
Author
There was a problem hiding this comment.
Great suggestion. I'll make the changes.
vepkenez
approved these changes
Aug 22, 2021
…t a warning when doing so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Feature
Required reviews:
2
What this does:
Keystore.import_securemethod for user-supplied entropy blobs for usage as keystore secrets.nucypher ursula|alice|bob init --key-material xxxto accept a user-supplied hex entropy blob to import.Issues fixed/closed:
Why it's needed:
Notes for reviewers