Merged
Conversation
c22d449 to
97fbcea
Compare
…returns - it should have some data representing confirmation.
97fbcea to
ff3f58b
Compare
7 tasks
Merged
7 tasks
vepkenez
approved these changes
Jul 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Initial documentation of Porter. Based over #2726 .
Issues fixed/closed:
Related to #2670 .
Notes for reviewers:
Build artifact available here - https://136953-100446516-gh.circle-artifacts.com/0/docs/build/html/application_development/porter.html.
This is an initial writeup of already implemented functionality up to "basic authentication" (#2726 ).
/revokeand/exec_work_orderAPIs haven't been implemented as yet.I would like to also add some application-specific documentation about specifics of using Porter aside from just stating the API. I intend to add this in separate PRs.
One mistake I made is doing documentation as a separate task, instead of providing a simple base document and then adding to the document as part of implementation PRs so that it builds up over time. To rectify that I'll merge this PR now as an initial base, and then add to it over time in subsequent PRs moving forward.