Basic Authentication for Porter#2726
Merged
KPrasch merged 5 commits intonucypher:porterfrom Jun 25, 2021
Merged
Conversation
Contributor
7220661 to
5a90d4e
Compare
Member
Author
@vepkenez the question becomes what do we provide out of the box vs what do we leave for people who intend to run Porter to customize for their own needs. As you mentioned, some of the more intricate functionality can be obtained via nginx proxy sitting in front of Porter, so we should think of where to draw the line. Let's chat more tomorrow. |
Closed
7 tasks
vepkenez
approved these changes
Jun 24, 2021
KPrasch
approved these changes
Jun 25, 2021
This was referenced Jun 25, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Type of PR:
Required reviews:
What this does:
Based over #2724 .
Allows Porter to facilitate Basic Authentication over HTTPS based on a provided
htpasswdfile via--basic-auth-filepath. Updated Docker/docker-compose files accordingly.Issues fixed/closed:
Fixes #2706 - does it fully "fix" it? perhaps for now unless users decide they want something more robust. However, this is a good starting point.
Why it's needed:
User authentication in some form will be needed if Porter is to be used as a public service.