TreasureMap con KFrags fixes, mostly with compatibility and splitting previous versions #2719
Merged
jMyles merged 18 commits intonucypher:chili-con-carnefrom Jun 9, 2021
Merged
Conversation
fjarri
reviewed
Jun 3, 2021
fjarri
reviewed
Jun 3, 2021
fjarri
reviewed
Jun 3, 2021
fjarri
reviewed
Jun 3, 2021
fjarri
reviewed
Jun 3, 2021
fjarri
added a commit
to fjarri/nucypher
that referenced
this pull request
Jun 3, 2021
fjarri
reviewed
Jun 3, 2021
fjarri
reviewed
Jun 3, 2021
…repeating it locally.
…t splitter for its version.
…lated concepts; it had been added back as part of a rebase to create a linear history.
19b7988 to
2b8c02e
Compare
Member
|
The CI failure for gas estimation looks like it can be resolved with a simple rename, might as well include it in this PR. |
KPrasch
approved these changes
Jun 7, 2021
Member
KPrasch
left a comment
There was a problem hiding this comment.
Great advancement - Definitely good enough to merge into the epic. I even suggest reducing the amount of required approvals to two.
fjarri
added a commit
to fjarri/nucypher
that referenced
this pull request
Jun 7, 2021
fjarri
reviewed
Jun 8, 2021
fjarri
reviewed
Jun 8, 2021
…ush it up before ever doing another WorkLock anyway.
95748d0 to
6d3cd88
Compare
fjarri
reviewed
Jun 8, 2021
fjarri
approved these changes
Jun 9, 2021
Contributor
fjarri
left a comment
There was a problem hiding this comment.
Approved with reservations to avoid blocking further work:
- I am still not sure that the
__new__approach is the best here, I'll revisit the topic when we have another versioned class and have to copy-paste or generalize. - In fact, I am not even certain that object versioning as opposed to protocol interactions versioning is the way to go, but this PR does not close the way to the latter yet.
- I think it is possible to make
SignedTreasureMapvalid on creation, and not after manually setting all the required fields with additional method calls - I'll try it out later.
7 tasks
fjarri
added a commit
to fjarri/nucypher
that referenced
this pull request
Jun 17, 2021
fjarri
added a commit
to fjarri/nucypher
that referenced
this pull request
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
Versions TreasureMaps, replaces some of @KPrasch's work within the class with the work @vepkenez had previously done to achieve very similar functionality. Also "brands" TreasureMaps - and distinctly, SignedTreasureMaps, for easy ascertainment across the network.
Updates depedencies.