Skip to content

Persistent TLS certificates; Simplify Ursula Initialization #2536

Merged
KPrasch merged 26 commits intonucypher:mainfrom
KPrasch:tamagatchi
Feb 19, 2021
Merged

Persistent TLS certificates; Simplify Ursula Initialization #2536
KPrasch merged 26 commits intonucypher:mainfrom
KPrasch:tamagatchi

Conversation

@KPrasch
Copy link
Copy Markdown
Member

@KPrasch KPrasch commented Jan 22, 2021 •
edited
Loading

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other - (Code Quality)

Required reviews:

  • 1
  • 2
  • 3

What this does:

  • Bugfix: Ensure that persistent public TLS certificates are used for worker servers
  • Ensure that persistent powers are derived from keyrings
  • Reduce and simplify internals of Ursula's construction
  • Stranger Ursulas no longer use a TLSHostingPower
  • Deprecates _set_checksum_address and reworks checksum setting logic

Why it's needed:

  • Improves node availability: Allows public TLS certificates to be properly reused for connection handshakes
  • Preserves browser security exceptions 🎉
  • Better readability and maintainability for characters

Notes for reviewers:

Co-Authorship

Co-Authored-By: vepkenez gdamon@gmail.com
Co-Authored-By: Derek Pierre derek.pierre@gmail.com

@KPrasch KPrasch added Bug 🐛 Broken functionality Ursula 👩‍🚀 Effects the "Ursula" development area Code Quality 🔧 Pertaining to code quality improvements labels Jan 22, 2021
@KPrasch KPrasch mentioned this pull request Jan 22, 2021
Closed
7 tasks
derekpierre
derekpierre reviewed Jan 22, 2021
View reviewed changes
KPrasch
KPrasch commented Jan 23, 2021
View reviewed changes
vepkenez
vepkenez reviewed Jan 23, 2021
View reviewed changes
@derekpierre derekpierre mentioned this pull request Jan 23, 2021
Closed
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Jan 23, 2021
@KPrasch
newsfragment for PR nucypher#2536
da8ba6b
KPrasch
KPrasch commented Jan 23, 2021
View reviewed changes
derekpierre added a commit to KPrasch/nucypher that referenced this pull request Jan 25, 2021
@derekpierre
Better organize serialization/deserialization functions.
56cbd50 
Use loopback address functions.
Respond to RFCs for nucypher#2536.
derekpierre added a commit to KPrasch/nucypher that referenced this pull request Jan 25, 2021
@derekpierre
Better organize serialization/deserialization functions.
7daf9c1 
Use loopback address functions.
Respond to RFCs for nucypher#2536.
@KPrasch KPrasch changed the title [WIP] Persistent TLS certificates; Simplify Ursula Initialization Persistent TLS certificates; Simplify Ursula Initialization Jan 25, 2021
@KPrasch KPrasch marked this pull request as ready for review January 25, 2021 21:58
@KPrasch
Copy link
Copy Markdown
Member Author

KPrasch commented Jan 25, 2021

Starting the review cycle on this PR

jMyles
jMyles reviewed Jan 26, 2021
View reviewed changes
KPrasch and others added 22 commits February 18, 2021 17:46
@KPrasch
Reworking checksum address setting logic and federated address deriva…
71eb29a 
…tion.
@KPrasch
Simplify Ursula construction: breakout functionality to methods, redu…
bda4db5 
…ce parameters, localize evidence.
@KPrasch
Handle power derivation from keyring, or ad-hoc usage of TLSHostingPo…
212abcc 
…wer.
@KPrasch
Understand Ursula.run as the coordinated single point of service star…
3777489 
…tup.
@KPrasch
Handle Vladimir stamp substantiation and missing asserts in test.
c6e402a
@KPrasch
Ursula persists her public TLS certificate.
6a18c02
@KPrasch
Additional cleanup and commentary
6574836
@derekpierre @KPrasch
Improve serialization/deserialization logic of private keys.
ab30f1f
@derekpierre @KPrasch
Ensure that when deserializer is not set, _read_keyfile returns the r…
a806534 
…aw bytes.
@KPrasch
Test adjustments and code touch ups
0b164b6
@derekpierre @KPrasch
Ensure that checksum_address, if provided, doesn't get overridden and…
d8ff912 
… is correct. Fix failing unit tests.
@derekpierre @KPrasch
Handle extra location where if checksum_address is provided, it shoul…
901b6d1 
…d match the worker's transaction account.
@KPrasch
Advance tests along with API changes and code touch ups
a4885c8
@vepkenez @KPrasch
keep Ursula checksum and worker address distinct
df80967
@derekpierre @KPrasch
Properly remove Vladimir from known_nodes when detected.
ea6e8a7
@KPrasch
newsfragment for PR nucypher#2536
7c8843f
@derekpierre @KPrasch
Better organize serialization/deserialization functions.
6f25d57 
Use loopback address functions.
Respond to RFCs for nucypher#2536.
@derekpierre @KPrasch
Fix failing unit tests.
bcfbf3e
@KPrasch
Ensure fleet state snapashot happens post-teacher-init
79ecaf3
@KPrasch
Keep Vlad's test imports local
d1e61f6
@derekpierre @KPrasch
Add unit tests for (de)serialization if keys from/to files.
cbe03d9
@derekpierre @KPrasch
Added unit and integration tests for keyring.
305bf0a
KPrasch added a commit to KPrasch/nucypher that referenced this pull request Feb 19, 2021
@KPrasch
Respond to RFCs for PR nucypher#2536; Holdover for future work; Post …
cc4133a 
…rebase cleanup.
@KPrasch KPrasch merged commit d4a925c into nucypher:main Feb 19, 2021
@KPrasch KPrasch mentioned this pull request Feb 26, 2021
Closed
@derekpierre derekpierre mentioned this pull request Apr 28, 2021
Closed
@KPrasch KPrasch deleted the tamagatchi branch October 25, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cygnusv cygnusv cygnusv approved these changes

@derekpierre derekpierre Awaiting requested review from derekpierre

@jMyles jMyles Awaiting requested review from jMyles

+2 more reviewers

@fjarri fjarri fjarri left review comments

@vepkenez vepkenez vepkenez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vepkenez vepkenez

@KPrasch KPrasch

@derekpierre derekpierre

Labels

Bug 🐛 Broken functionality Code Quality 🔧 Pertaining to code quality improvements Ursula 👩‍🚀 Effects the "Ursula" development area

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@KPrasch @cygnusv @derekpierre @fjarri @vepkenez @jMyles