Fixes debug docker problem.#1095
Merged
KPrasch merged 12 commits intonucypher:epic-schabowskifrom Jun 22, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## epic-schabowski #1095 +/- ##
===================================================
+ Coverage 74.84% 78.93% +4.08%
===================================================
Files 67 67
Lines 8783 8790 +7
===================================================
+ Hits 6574 6938 +364
+ Misses 2209 1852 -357
Continue to review full report at Codecov.
|
…turns out that's *not* the problem in nucypher#941.
…el. A good-enough compromise for now I guess.
…t, on which test assertion relies.
michwill
approved these changes
Jun 22, 2019
KPrasch
reviewed
Jun 22, 2019
| # Async Sentinel | ||
| except Exception as e: | ||
| log.critical(str(e)) | ||
| log.critical(f"This exception really needs to be handled differently: {e}") |
KPrasch
reviewed
Jun 22, 2019
| continue | ||
| except NotFound: | ||
| # This Ursula claims not to have a matching KFrag. Maybe this has been revoked? | ||
| # TODO: What's the thing to do here? Do we want to track these Ursulas in some way in case they're lying? |
KPrasch
approved these changes
Jun 22, 2019
fjarri
added a commit
to fjarri/nucypher
that referenced
this pull request
Jun 26, 2019
fjarri
added a commit
to fjarri/nucypher
that referenced
this pull request
Jul 17, 2019
fjarri
added a commit
to fjarri/nucypher
that referenced
this pull request
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #941 and also many of the issues that made it so difficult to track down the problem.
--log-levelto top-levelnucypherCLI interface.--interactivetonucypher ursula ...-UrsulaCommandProtocolnow only launches if this flag is provided.