Extract Worker actor from Staker#1058
Merged
cygnusv merged 40 commits intonucypher:alhambra-verdefrom Jun 18, 2019
Merged
Conversation
KPrasch
reviewed
Jun 7, 2019
Codecov Report
@@ Coverage Diff @@
## alhambra-verde #1058 +/- ##
==================================================
- Coverage 84.26% 82.62% -1.64%
==================================================
Files 68 68
Lines 8731 8910 +179
==================================================
+ Hits 7357 7362 +5
- Misses 1374 1548 +174
Continue to review full report at Codecov.
|
ffdb6f6 to
e2a3ec9
Compare
427c3fb to
8a26dd5
Compare
KPrasch
reviewed
Jun 11, 2019
8 tasks
4eca13d to
b1572a7
Compare
9afc40d to
db25f87
Compare
This was referenced Jun 14, 2019
Closed
…aut-tolerance test.
Member
|
Follow up to |
KPrasch
approved these changes
Jun 17, 2019
tuxxy
approved these changes
Jun 18, 2019
vzotova
reviewed
Jun 18, 2019
The only way to use setWorker without waiting is that there's no worker set.
vzotova
approved these changes
Jun 18, 2019
cygnusv
added a commit
that referenced
this pull request
Jun 18, 2019
Extract Worker actor from Staker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to crystallize the implications of #1003, i.e., the separation of Ursula in two: Worker and Staker. Now Ursulas are worker nodes, while NU holders are stakers (either of human or contract nature).
Most drastic changes occur at the actor level (since now the old
Stakeractor was separated intoStakerandWorker) and at theTeacherlevel, since now teacher nodes (which inherit fromWorker) have to implement the new ways of identity validation (as per #1003), which include off-chain and on-chain means.Side note: this was a fun PR. @KPrasch and I were working on it in turns, taking advantage of our almost complementary time zones. There wasn't too much need to talk. Just wake up in the morning, drink some coffee,
git remote updateand continue from where the other left.