Skip to content

Remove statefullness from DKG instances#183

Merged
piotr-roslaniec merged 6 commits intonucypher:rocknrollfrom
piotr-roslaniec:remove-dkg-state
Mar 19, 2024
Merged

Remove statefullness from DKG instances#183
piotr-roslaniec merged 6 commits intonucypher:rocknrollfrom
piotr-roslaniec:remove-dkg-state

Conversation

@piotr-roslaniec
Copy link
Copy Markdown

@piotr-roslaniec piotr-roslaniec commented Feb 14, 2024 •
edited
Loading

Type of PR:

  • Feature
  • Refactor

Required reviews:

  • 1

What this does:

  • Removes statefulness from struct Dkg
  • Rewrites logic that relied on the internal state, for example, transcript verification
  • Removes deprecated structures and methods (mostly related to Message)
  • Fixes some serde serialization issues that came up in Key share refreshing ceremony refactor #175

Issues fixed/closed:

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

@piotr-roslaniec piotr-roslaniec force-pushed the remove-dkg-state branch 4 times, most recently from a9e7f44 to 2e7835c Compare February 19, 2024 13:21
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 19, 2024 •
edited
Loading

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (72b8484) 78.28% compared to head (07c476c) 79.28%.
Report is 1 commits behind head on main.

Files Patch % Lines
ferveo/src/bindings_python.rs 59.33% 61 Missing ⚠️
ferveo/src/api.rs 94.72% 38 Missing ⚠️
ferveo-tdec/src/decryption.rs 39.13% 14 Missing ⚠️
ferveo/src/bindings_wasm.rs 0.00% 9 Missing ⚠️
ferveo/src/dkg.rs 92.62% 9 Missing ⚠️
ferveo-tdec/src/key_share.rs 50.00% 3 Missing ⚠️
ferveo/src/refresh.rs 98.63% 3 Missing ⚠️
ferveo-common/src/keypair.rs 0.00% 1 Missing ⚠️
ferveo/src/pvss.rs 99.24% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   78.28%   79.28%   +1.00%     
==========================================
  Files          24       24              
  Lines        5066     5721     +655     
==========================================
+ Hits         3966     4536     +570     
- Misses       1100     1185      +85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review February 22, 2024 14:41
@piotr-roslaniec piotr-roslaniec mentioned this pull request Feb 22, 2024
Merged
@cygnusv cygnusv changed the base branch from main to rocknroll March 19, 2024 09:43
@piotr-roslaniec piotr-roslaniec merged commit aa69b36 into nucypher:rocknroll Mar 19, 2024
@piotr-roslaniec piotr-roslaniec deleted the remove-dkg-state branch March 19, 2024 11:16
This was referenced Mar 19, 2024
Closed
Closed
@derekpierre derekpierre mentioned this pull request Aug 15, 2025
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get rid of g_inv and h_inv in the API Remove the remainder of statfulness from the DKG instances

2 participants

@piotr-roslaniec @codecov-commenter