Key share refreshing ceremony refactor#175
Merged
cygnusv merged 3 commits intonucypher:rocknrollfrom Mar 19, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 78.28% 79.76% +1.47%
==========================================
Files 24 24
Lines 5066 5856 +790
==========================================
+ Hits 3966 4671 +705
- Misses 1100 1185 +85 ☔ View full report in Codecov by Sentry. |
da8614a to
039f329
Compare
e1f6ac9 to
cf281c4
Compare
cf281c4 to
779a7bb
Compare
779a7bb to
4713848
Compare
cygnusv
approved these changes
Mar 19, 2024
Member
cygnusv
left a comment
There was a problem hiding this comment.
Approved! This is the foundation for the work for Refresh & Recovery, laying out a better codebase to accommodate the required changes
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
newtypestructsserdeserdecan't handleserde_asforcrate::*for some reason.external_crate::*works just finePrivateKeyShareand its derivatives used in refreshing and recovery are now a part of the public API. This should help decouple them fromAggregateTranscript.AggregateTranscriptare not deprecated yet - Awaiting more details on a new design, to be addressed in future PR.Issues fixed/closed:
Why it's needed:
Notes for reviewers: